davepl
commented
1 month ago Good feedback!
The UNITY flag forces doubles to be the same size on the ESP32 and the x86 so that they can share data. There’s a Unity project that can render video and graphics and send them to the mesmerizer, but it only works if you spec the float size.
As to the specifics of size, they are lost to the ages now. Which is to say “I forget”!
- Dave
On May 13, 2024, at 6:14 AM, Robert Lipe @.***> wrote:
@robertlipe approved this pull request.
Looks good! Nice use of modern C++ for time. Minor style bits for consistency.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598394778:
- callback(StockData()); // HTTP request error
- }
- http.end(); // Close the connection properly
- }
- // GetAllQuotes
- //
- // Retrieves all quotes for the given list of symbols, provided as a comma-separated string
- // Calls getQuote for each symbol in the list, and saves it in the stockData map
- void GetAllQuotes(const String& symbols, StockDataCallback callback = nullptr)
- {
- // Lambda to split the symbols string by comma, because somehow this is cooler than strtok() was in 1989
- // and I want to flex, but also because strtok() is not thread-safe and we're using threads here. So there.
- // Also, I'm using std::string here because std::getline() is easier to use with std::string than with String. Fwiw, I have very similar code sitting in a branch for the same reasons. Expect to see something like this in utils some day.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598396032:
- callback(StockData()); // Parsing error
- }
- }
- else
- {
- Serial.printf("[HTTP] GET failed, error: %s\n", http.errorToString(httpCode).c_str());
- if (callback)
- callback(StockData()); // HTTP request error
- }
- http.end(); // Close the connection properly
- }
- // GetAllQuotes
- //
- // Retrieves all quotes for the given list of symbols, provided as a comma-separated string Please end sentences in periods throughout.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598399561:
+class PatternStocks : public LEDStripEffect +{
- AnimatedText textSymbol = AnimatedText("STOCK", CRGB::White, &Apple5x7, 1.0f, MATRIX_WIDTH, 0, 0, 0);
- AnimatedText textPrice = AnimatedText("PRICE", CRGB::Grey, &Apple5x7, 1.0f, MATRIX_WIDTH, 8, 0, 8);
- AnimatedText textChange = AnimatedText("CHANGE", CRGB::White, &Apple5x7, 1.0f, MATRIX_WIDTH, 16, 0, 16);
- AnimatedText textVolume = AnimatedText("VOLUME", CRGB::Grey, &Apple5x7, 1.0f, MATRIX_WIDTH, 24, 0, 24);
+private:
- int iCurrentStock = 0;
- bool isUpdating = false; // Flag to check if update is in progress
- system_clock::time_point lastUpdate; // Time of last update
- system_clock::time_point nextFetch = system_clock::now(); // Time of last quote pull
- std::map<String, StockData> stockData; // map of stock symbols to quotes Bonus points for modern time handling. SO much easier to read than struct timeval.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598405012:
- stockData.close = doc["close"].as
(); - stockData.volume = doc["volume"].as
(); - for (JsonVariant point : doc["points"].as
()) - {
- StockPoint stockPoint;
- stockPoint.dt = system_clock::from_time_t(point["dt"].as
()); - stockPoint.val = point["val"].as
(); - stockData.points.push_back(stockPoint);
- }
- if (callback)
- callback(stockData); // Successful retrieval and parsing
- }
- else
- {
- Serial.printf("Failed to parse JSON: %s\n", error.c_str()); Consider DebugE so it shows in red.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598405664:
- stockPoint.val = point["val"].as
(); - stockData.points.push_back(stockPoint);
- }
- if (callback)
- callback(stockData); // Successful retrieval and parsing
- }
- else
- {
- Serial.printf("Failed to parse JSON: %s\n", error.c_str());
- if (callback)
- callback(StockData()); // Parsing error
- }
- }
- else
- {
- Serial.printf("[HTTP] GET failed, error: %s\n", http.errorToString(httpCode).c_str()); Likewise.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598411553:
+
- for (const String& symbol : symbolList)
- {
- GetQuote(symbol, [this, callback](const StockData& stockDataReceived)
- {
- if (!stockDataReceived.symbol.isEmpty()) // Check if the stock data is not empty
- this->stockData[stockDataReceived.symbol] = stockDataReceived;
- if (callback)
- callback(stockDataReceived); // Optionally, call the callback for each symbol's data
- });
- }
- }
- // Should this effect show its title.
- // The stocks effect does not show a title so it doesn't obscure our text display ? And stock's. Also, inconsistent period use.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598415815:
+
- PatternStocks() : LEDStripEffect(EFFECT_MATRIX_STOCKS, "Stocks")
- {
- }
- PatternStocks(const JsonObjectConst& jsonObject) : LEDStripEffect(jsonObject)
- {
- }
- ~PatternStocks()
- {
- }
- static void FetchQuotesTask(void *pvParameters)
- {
- auto instance = static_cast<PatternStocks>(pvParameters); // Cast the void pointer back to the correct type Musing: why can't auto deduce the right type here? Is the type really a Patternstocks**?
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598430413:
- int w = MATRIX_WIDTH;
- int h = MATRIX_HEIGHT - y;
- int n = std::min((uint)MATRIX_WIDTH, currentStock.points.size());
- if (n > 0)
- {
- float max = 0.0f;
- float min = numeric_limits
::max(); - // We have the high and low data in the stock, but let's not trust it and calculate it ourselves
- for (int i = 0; i < n; i++)
- {
- max = std::max(max, currentStock.points[i].val);
- min = std::min(min, currentStock.points[i].val);
- } Is this (min, max) = std::minmax_element(points.begin(), points.end()); That allows simd use and possible unrolling if size is known.
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598432873:
- g()->drawLine(x0, y0, x1, breakevenY, CRGB::Green);
- }
- }
- }
- }
- // Draw
- //
- // Draws the stock display made up of four animated text flyers (price, symbol, change, volume)
- // and the stock history graph
- void Draw() override
- {
- static uint lastCount = 0;
- //static StockData stockData; Stray?
In include/effects/matrix/PatternStocks.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598433314:
+
- // Draw
- //
- // Draws the stock display made up of four animated text flyers (price, symbol, change, volume)
- // and the stock history graph
- void Draw() override
- {
- static uint lastCount = 0;
- //static StockData stockData;
- g()->fillScreen(BLACK16);
- g()->fillRect(0, 0, MATRIX_WIDTH, 9, g()->to16bit(CRGB(0,0,128)));
- // Periodically refecth the stock data from the server Typos.
In include/gfxbase.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598438170:
}void drawPixel(int16_t x, int16_t y, uint16_t color) override { if (isValidPixel(x, y)) leds[XY(x, y)] = from16Bit(color);
- else Should these just become asserts as they indicate a programming error?
In include/globals.h https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598442632:
@@ -1326,7 +1312,7 @@ extern RemoteDebug Debug; // Let everyone in the project know about it
#define USE_M5DISPLAY 1 // enable the M5's LCD screen
elif ESP32FEATHERTFT || PANLEE || LILYGOTDISPLAYS3
elif USE_TFTSPI || ESP32FEATHERTFT || PANLEE || LILYGOTDISPLAYS3
Consider just moving use-tftspi into those three build definitions?
We have a constant tension of the build and the config trying to outsmart each other...
In platformio.ini https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598447559:
@@ -30,8 +30,8 @@ extra_configs = ; Options that are used (or extended) in all device sections (and hence environments) are defined here
[base] -upload_port = -monitor_port = +upload_port = +monitor_port = No trailing spaces, please. This causes diff thrash.
In platformio.ini https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#discussion_r1598449218:
+monitor_speed = 115200 +upload_speed = 1500000 +board_build.partitions = config/partitions_custom_noota.csv
+build_flags = ${base.build_flags}
- -DLILYGO_TDISPLAY_AMOLED_SERIES=1
- -DARDUINO_USB_CDC_ON_BOOT=1
- -DAMOLED_S3=1
- -DUSE_SCREEN=1
- -DTOGGLE_BUTTON_1=21
- -DTOGGLE_BUTTON_2=0
- -DNUM_INFO_PAGES=2
- -DLED_PIN0=2
- -DLV_CONF_PATH="../../../../include/amoled/lv_conf.h"
- -DLV_CONF_INCLUDE_SIMPLE
- ${psram_flags.build_flags}
- ${unity_double_flags.build_flags} What does this have to do with Unity?
— Reply to this email directly, view it on GitHub https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/626#pullrequestreview-2052567410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4HCFYOVIQ4OJ4T5LXS3KLZCC4D7AVCNFSM6AAAAABHTMRH76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJSGU3DONBRGA. You are receiving this because you authored the thread.
Thermotronica
robertlipe
rbergen
Description
Adds a new Stock effect and the required API, as well as AMOLED S3 support
Contributing requirements
mainas the target branch.