PlummersSoftwareLLC / NightDriverStrip

NightDriver client for ESP32
https://plummerssoftwarellc.github.io/NightDriverStrip/
GNU General Public License v3.0
1.29k stars 210 forks source link

HSV Shifting Flame Effect #631

Closed drevastation closed 2 weeks ago

drevastation commented 2 weeks ago

Description

This adds a strip effect called fireHueShift.h. I'm running the youtube tutorial version of code, not the full nightdriver. Apologies for any way that this doesn't properly conform, please modify it as necessary. If you want me to do that work myself, please just reject this request, and I'll be able to get around to it soon.

I'm including my favorite shifts below. The first shows the full format of the method call, all else are abbreviated.

Icy: FireHueEffect fireHA0(g_LED_BAR0, g_NUM_LIGHTBAR_LEDS, CHSV(160,10,255),CHSV(150,254,200), byte(128), CHSV(145,255,180), CounterClockwise, Coolingh, Sparkingh, Sparksh, SparkHeighth, bReversed, bMirrored);

Soul Flame: CHSV(148,96,255),CHSV(135,255,200), byte(128), CHSV(97,255,180), CounterClockwise,

Better fire: CHSV(64,10,255),CHSV(40,254,200), byte(220), CHSV(7,255,180), CounterClockwise,

Malice from Zelda: CHSV(200,10,255),CHSV(253,254,255), byte(64), CHSV(254,255,240), Clockwise,

Retrowave: CHSV(13,255,255),CHSV(5,255,200), byte(150), CHSV(200,255,60), CounterClockwise,

Prismatic Ember: CHSV(150,240,255),CHSV(30,255,200), byte(96), CHSV(13,255,150), CounterClockwise,

Contributing requirements

rbergen commented 2 weeks ago

@drevastation Reading the comment you make about this yourself, I think you already know what I'm going to say: considering you're proposing an addition to NightDriverStrip, you should indeed make sure it's a "proper" NightDriverStrip effect, that it's used by at least one project/configuration (otherwise you're effectively adding dead code) and that you've tested it in that context.

In line with your own request, I will close this PR, for now.