PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python
https://plummerssoftwarellc.github.io/PrimeView/
2.46k stars 573 forks source link

Prime JavaScript #849

Closed DiefBell closed 2 years ago

DiefBell commented 2 years ago

Description

Converted PrimeNodeJS to PrimeJavaScript as NodeJS is the runtime, not the language, and this also allows us to run on other runtimes.

This has been created in response to the comment left on my previous PrimeBun pull request: https://github.com/PlummersSoftwareLLC/Primes/pull/848#issuecomment-1179072059

rbergen commented 2 years ago

@DiefBell Thank you for submitting this and including Deno in the updated solution. That's highly appreciated!

rbergen commented 2 years ago

The docker build fails for this solution. It looks like the bun:edge Docker image is based on Alpine, which means apt-get isn't available.

DiefBell commented 2 years ago

It was Ubuntu based yesterday.... 🤦 I'll go sort

DiefBell commented 2 years ago

This is definitely still Ubuntu based, and I can build it locally no problem... Really not sure what the issue is here, will keep investigating

rbergen commented 2 years ago

I'm basing my Alpine conclusion mainly on this layer in the bun:edge image:

ENV GLIBC_REPO=https://github.com/sgerrand/alpine-pkg-glibc

Taking steps to include glibc is indeed common in Alpine, as it doesn't include it by default.

DiefBell commented 2 years ago

Turns out Docker was caching something somewhere, after a prune I've got this error too. Will sort it out

DiefBell commented 2 years ago

Should be good to go

DiefBell commented 2 years ago

Fixed

DiefBell commented 2 years ago

LGTM?

rbergen commented 2 years ago

Looks Good To Me. That's me telling the second maintainer I'm happy to merge if he also agrees.