PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python
https://plummerssoftwarellc.github.io/PrimeView/
2.44k stars 575 forks source link

Bitmasks #862

Closed rogiervandam closed 1 year ago

rogiervandam commented 1 year ago

Description

Made significant speed improvements by grouping writes to memory:

Contributing requirements

DiefBell commented 1 year ago

I don't think .DS_Store files should be committed.

rogiervandam commented 1 year ago

I don't think .DS_Store files should be committed.

Corrected. Thanks.

DiefBell commented 1 year ago

There's still a .DS_Store file in the root. @rbergen should we get this added to a .gitignore?

rbergen commented 1 year ago

@DiefBell with @rogiervandam having closed the PR I am not sure how relevant my answer to your question still is, but I'll give it anyway. The .DS_Store in the root is not part of the repository now, but would (have) be(en) introduced with the PR. It should simply not be included in it.

rogiervandam commented 1 year ago

Accidentally closed request. Reopend.

rbergen commented 1 year ago

@rogiervandam It seems that the introduction of the require('perf_hooks') in PrimeJavaScript.js and PrimeJavaScript_memcopy.js breaks the Deno runs. This is the output I get when I execute a docker run locally:

rogiervandam-node;5705;5.0000431320000205;1;algorithm=base,faithful=yes,bits=1

rogiervandam-bun;8928;5.000083417;1;algorithm=base,faithful=yes,bits=1
error: Uncaught ReferenceError: require is not defined
const { performance } = require('perf_hooks');
                        ^
    at file:///opt/app/PrimeJavaScript.js:20:25

rogiervandam-memcopy-node;11735;5.000339586999965;1;algorithm=other,faithful=yes,bits=1
error: Uncaught ReferenceError: require is not defined
const { performance } = require('perf_hooks');
                        ^
    at file:///opt/app/PrimeJavaScript_memcopy.js:20:25

rogiervandam-memcopy-bun;17618;5.000472283;1;algorithm=other,faithful=yes,bits=1

rogiervandam-cluster-base-node;14617;5.053010843999917;4;algorithm=base,faithful=yes,bits=1

rogiervandam-cluster-memcopy-node;30172;5.058445269000018;4;algorithm=other,faithful=yes,bits=1

diefbell-worker-node;13135;5.071487028000061;4;algorithm=base,faithful=yes,bits=1

I assume this is not intentional?

rogiervandam commented 1 year ago

@rogiervandam It seems that the introduction of the require('perf_hooks') in PrimeJavaScript.js and PrimeJavaScript_memcopy.js breaks the Deno runs. This is the output I get when I execute a docker run locally:

rogiervandam-node;5705;5.0000431320000205;1;algorithm=base,faithful=yes,bits=1

rogiervandam-bun;8928;5.000083417;1;algorithm=base,faithful=yes,bits=1
error: Uncaught ReferenceError: require is not defined
const { performance } = require('perf_hooks');
                        ^
    at file:///opt/app/PrimeJavaScript.js:20:25

rogiervandam-memcopy-node;11735;5.000339586999965;1;algorithm=other,faithful=yes,bits=1
error: Uncaught ReferenceError: require is not defined
const { performance } = require('perf_hooks');
                        ^
    at file:///opt/app/PrimeJavaScript_memcopy.js:20:25

rogiervandam-memcopy-bun;17618;5.000472283;1;algorithm=other,faithful=yes,bits=1

rogiervandam-cluster-base-node;14617;5.053010843999917;4;algorithm=base,faithful=yes,bits=1

rogiervandam-cluster-memcopy-node;30172;5.058445269000018;4;algorithm=other,faithful=yes,bits=1

diefbell-worker-node;13135;5.071487028000061;4;algorithm=base,faithful=yes,bits=1

I assume this is not intentional?

Missed this. Thanks. Resolved.

rbergen commented 1 year ago

LGTM