updated concurrent-ruby gem

PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python

https://plummerssoftwarellc.github.io/PrimeView/

2.43k stars 575 forks source link

updated concurrent-ruby gem #915

Closed darnellbrawner closed 1 year ago

darnellbrawner commented 1 year ago

Description

upgraded concurrent-ruby gem to latest

Contributing requirements

[x] I read the contribution guidelines in CONTRIBUTING.md.
[x] I placed my solution in the correct solution folder.
[x] I added a README.md with the right badge(s).
[x] I added a Dockerfile that builds and runs my solution.
[x] I selected drag-race as the target branch.
[x] All code herein is licensed compatible with BSD-3.

rbergen commented 1 year ago

Thanks for submitting this. Based on your comment on #907 I assume you have not been able to personally verify if the version bump of concurrent-ruby actually fixes that issue. Is that correct?

EDToaster commented 1 year ago

Confirmed that the program does terminate under a minute, down from 4 hours!

❯ ruby --jit -W0 prime.rb
darnellbrawner-Numo;829;5.005;1;algorithm=base,faithful=no
darnellbrawner-MultiThreaded;1;19.638;96;algorithm=base,faithful=yes
darnellbrawner-MultiThreaded-Numo_2core;1;26.375;2;algorithm=base,faithful=no

rbergen commented 1 year ago

Great, I'm very happy to hear that. I'll run CI and merge if that passes.

@EDToaster and @darnellbrawner Many thanks to both of you for reporting and following up!