Pure Python Performance improvement

PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python

https://plummerssoftwarellc.github.io/PrimeView/

2.43k stars 574 forks source link

Pure Python Performance improvement #928

Closed ddi-kkugler closed 1 year ago

ddi-kkugler commented 1 year ago

Description

Use python array slicing to improve performance. No additional libraries, follows same structure as solution 1. Syntactically it is more difficult to read, but functionally does exactly the same thing.

NOTE: the downstream repo davepl/Primes has a couple other commits different than this repo, I only added changes to PrimePython/solution_1/PrimePY.py

[x] I read the contribution guidelines in CONTRIBUTING.md.
[x] I placed my solution in the correct solution folder.
~[ ] I added a README.md with the right badge(s).~ (Not applicable)
~[ ] I added a Dockerfile that builds and runs my solution.~ (Not applicable)
[x] I selected drag-race as the target branch.
[x] All code herein is licensed compatible with BSD-3.

rbergen commented 1 year ago

@ddi-kkugler Thanks for your submission.

I have no reason to doubt your intention about what it is your PR changes (i.e. PrimePython/solution_1/PrimePY.py). However, your PR currently does contain changes to PrimeCSharp/solution_2 and PrimeREXX/solution_2. We can't pull these in with a change to the Python solution.

I think it would be good to rebase your PR branch to the current state of PlummersSoftwareLLC/Primes:drag-race; what matters is that only the intended changes to PrimePython/solution_1/PrimePY.py show up in the "Files changed" tab within the PR.

ddi-kkugler commented 1 year ago

Fair enough, the other commits were made by you and/or Dave himself so I (foolishly) figured they should be included in this repo. A few of the videos in Dave's Software Drag Racing series (1, 2, 3) link to davepl/Primes, and a few link to PlummersSoftwareLLC/Primes. Looks like you want PlummersSoftwareLLC/Primes to be the main upstream repo, so it would be nice to update the comment in those videos linked above to point to the correct repo.

rbergen commented 1 year ago

A few of the videos in Dave's Software Drag Racing series (1, 2, 3) link to davepl/Primes, and a few link to PlummersSoftwareLLC/Primes. Looks like you want PlummersSoftwareLLC/Primes to be the main upstream repo, so it would be nice to update the comment in those videos linked above to point to the correct repo.

That's fair. I don't have access to things at the YouTube side, but I will pass that on to Dave.