Closed rzuckerm closed 11 months ago
@rzuckerm Thanks for this submission. However, as it is in part an improvement on an existing solution, I think we should indeed structure it as an iteration on PrimeBASIC/solution_4. That is to say: apply the algorithm improvements to the implementation that's already there, and add the 1-bit implementation to it. For one, Dave has said multiple times himself that he prefers improvements to existing solutions over the creation of new, deduced ones - his own are no exception.
Of course, it's perfectly fine to take credit for the improvement/addition in the solution's README.md and implementation output. As always, I'm happy to help with the phrasing of things if needed.
Please do retain the possibility to run the solution without Docker that PrimeBASIC/solution_4 now offers.
@rbergen How would I annotate the original solution? Would I retain the davepl
? For the output, would I list the original result, or would I list the results that I got for the old implementation vs. the new?
In the 1-bit implementation you can obviously just tag yourself. In the one you improve I'd go for davepl-rzuckerm
- in the end that implementation is effectively co-authored.
The output should reflect the output of whatever is the solution in its current state. In other words, that should be replaced by the output of the solution after you've modified it.
Description
This is an improvement on the Microsoft Basic v2 solution by davepl. In addition, it contains a 1-bit version which can handle sieve size up to 100000
Contributing requirements
drag-race
as the target branch.