search

PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python
https://plummerssoftwarellc.github.io/PrimeView/
2.43k stars 574 forks source link

OCaml solutions don't build with current version of OCaml #958

Closed rbergen closed 6 months ago

rbergen commented 6 months ago

While updating a number of Docker images published on Docker Hub in the context of this project, I found that the OCaml solutions don't build with a current version of OCaml (5.1, to be precise). Two reasons I've been able to identify but also noting that there may be more:

Personally, I am definitely not sufficiently knowledgeable about OCaml to make the modifications that would be required to make the solutions build again.

Without wanting to imply any obligation to look into this by the solutions' author @gkpotter, I'm calling out to him specifically in case he would be willing and able to do so.

gkpotter commented 6 months ago

I will look into this!

rbergen commented 6 months ago

@gkpotter Thank you, I really appreciate that. Let me know if I can help with anything, like the composition of the base image the solutions now use. The Docker Hub link to that image is https://hub.docker.com/r/primeimages/ocaml.
The Dockerfile that produces that image can be found here: https://github.com/PlummersSoftwareLLC/OCaml-docker.