PlummersSoftwareLLC / Primes

Prime Number Projects in C#/C++/Python
https://plummerssoftwarellc.github.io/PrimeView/
2.43k stars 575 forks source link

Updated OCaml solutions to fix issue (#958) #962

Closed gkpotter closed 6 months ago

gkpotter commented 6 months ago

Description

Updated OCaml solutions to use Dune and the latest version of OCaml to fix #958.

Contributing requirements

rbergen commented 6 months ago

@gkpotter Thank you so much! I'm currently running CI on this, which I already know will yield some complaints from Hadolint, our Dockerfile linter. Please let me know if you're ok with addressing those, or if you'd like me to take care of that for you - which will require me to update your main branch.

Correction: CI actually fails because the base images you refer to are untagged - I forgot Hadolint marks this as an error instead of a warning. The "latest" version of the primeimages/ocaml image is 5.1, for the alpine image that would be 3.19.

gkpotter commented 6 months ago

Glad I could help keep this project up to date!