Sunderlandkyl
commented
7 years ago 2013-08-05 11:08 Adam Rankin Attempting to find a solution that doesnt' change the repo structure, only the download command.
May replace SVN_REPOSITORY in External_PlusLib command with a custom DOWNLOAD_CMD that does/does not download the TestImages directory.
2013-08-06 09:45 Adam Rankin @lassoan an alternative I see is to place the data in another root directory called PlusData (or something) and have that as an external project that downloads to the pluslib/data/testimages directory...
thoughts?
2013-08-06 09:49 Adam Rankin The downside to the PlusData approach is that the location of the folder would be another cmake variable who's path would have to match the repo structure.
With the first approach, the path could be embedded in the CMake file as part of the command.
I can't visualize a way around manually entering the path in a variable or file...
2013-08-06 11:06 Andras Lasso It's important that src and data directories are kept consistent (for a specific version of the source code there is matching version of the test data). At some point, there was no common root directory of the src and data directories, but it was very difficult to keep the data and source consistent.
I see two options: Option A: Keep the directory structure as is, just review the files and move the non-essential ones elsewhere and reduce the size of the rest. Option B: Use the CMake ExternalData method (http://www.kitware.com/source/home/post/107), preferably with an SVN repository.
2013-08-06 11:20 Andras Lasso For me, this is a low priority item (I'm not fully convinced that we really need this), as it makes Plus build somewhat more convenient for users who don't want to run tests (do we want to help this practice??), but makes the build system more complex for everybody.
2013-08-06 13:37 Tamas Ungi Right now, when PLUS users (who build their own PLUS) ask me about how to set up IGT systems, it's so good that I can send them simple instructions using a config file and a saved example data from the PLUS repo (already on their computer). They can effortlessly start a tracked ultrasound simulator. I'm sorry to hear that the example data will not be part of PLUS, as it will be a lot more complicated to show them how PLUS works on their computer.
2013-08-06 16:46 Adam Rankin @ungi If we end up doing this change, nothing will change for users. The option would be enabled by default and advanced users could elect not to download the test data.
Essentially nothing would change to the user except if you didn't want to download 430MB of test/example data, you don't have to.
2013-08-06 16:46 Adam Rankin @lassoan yes I agree, not high priority. I was just wondering if there was a clean way of making the data download optional, enabled by default.
2016-03-24 11:14 Andras Lasso re #804: Fixed documentation file references to files in PlusLibData directory Committed to: plus In plus:4572
2016-03-24 11:16 Andras Lasso re #804: Fixed documentation file references to files in PlusLibData directory Committed to: plus In plus:4573
Separate code checkout and data checkout.
Migrated from https://app.assembla.com/spaces/plus/tickets/804/details