search

PlusToolkit / PlusLib

Software library for data acquisition, pre-processing, and calibration for navigated image-guided interventions.
http://www.plustoolkit.org
Other
130 stars 102 forks source link

VTK/ITK not packaging correctly #547

Open Sunderlandkyl opened 5 years ago

Sunderlandkyl commented 5 years ago

100% related to the change to VTK/ITK directory (https://github.com/PlusToolkit/PlusBuild/pull/51).

The package step now fails when packaging VTK:

------ Build started: Project: PACKAGE, Configuration: Release x64 ------
CPack: Create package using ZIP
CPack: Install projects
CPack: - Install project: PlusApp
CPack: - Install project: PlusLib
CPack: - Install project: PlusLib
CPack: - Install project: PlusLib
CPack: - Install project: VTK
EXEC : CPack error : Error when generating package: PlusApp

Running CPack with --verbose does not add any additional output in the VTK step.

If no-one has any ideas, then I'll drop a message on the CMake mailing list.

Sunderlandkyl commented 5 years ago

I can get packaging to succeed by using the binary directory instead of the installed directory here: https://github.com/PlusToolkit/PlusApp/blob/d57c1fb0a2b9ce2d5536c83a4debf8069464c160/CPackConfig.cmake#L88

I don't think it's the correct solution, surely packaging should be possible using the installed VTK?

Sunderlandkyl commented 5 years ago

@lassoan @adamrankin

lassoan commented 5 years ago

The huge include directory list is a problem caused by VTK and ITK, so I think the most appropriate place to ask is the VTK and ITK forums. VTK build system has profoundly changed between 8.2 and latest master 8.90 but I hope we can get advice that works for both.

Sunderlandkyl commented 5 years ago

Posted a message to the VTK forum (https://discourse.vtk.org/t/packaging-with-an-installed-version-of-vtk/933).

Until we have a solution, I've implemented a workaround that at least allows Plus to package successfully.

jamesobutler commented 5 years ago

Just following up, @Sunderlandkyl Is there still actions left to do for this issue? Or is this like #551?

Sunderlandkyl commented 5 years ago

I'd like to keep this issue open for now. There is still a workaround in place ( https://github.com/PlusToolkit/PlusApp/commit/2aa39cfd78376d63eec0f9977962de44f8f8f755, https://github.com/PlusToolkit/PlusApp/commit/2aa39cfd78376d63eec0f9977962de44f8f8f755) and at some point I'll come back to it and fix packaging without the workaround.