Closed dzhoshkun closed 6 years ago
It's beyond me why GitHub shows 76 different commits here, while the to-be-merged commits are much less than that. I've merged my issue branch onto my own master branch. So will close this PR and submit a new one directly from my own master branch. That might resolve this problem.
The C extension module has been refactored with C macros that enable conditional compilation based on the Python version (closes dzhoshkun/ndicapi#11). The changes have been tested with both Python versions on:
(For the details of the testing procedure, please see dzhoshkun/ndicapi#14)
Other notable changes this PR introduces:
setup.py
file.pip install
. This is a cleaner way to install the extension module, as it takes care of removing all components (including the installed dynamic library file, i.e.ndicapy.so
on Linux) whenpip install ndicapi
is called.BUILD_SHARED_LIBS
is nowON
by default (the Python extension module requires a shared library).pyndicapi
tondicapy
as the latter is shorter and more Pythonic. Closes dzhoshkun/ndicapi#13The following guidelines / documentation links are useful for porting Python 2 extension modules to Python 3: