Plushtoast / TDE-Roll20-Official

Das Schwarze Auge / The Dark Eye 5th Ed. System for Roll20
8 stars 2 forks source link

Fix checkbox sizing for longer strings #223

Closed LorenzCK closed 11 months ago

LorenzCK commented 1 year ago

This issue is to track changes submitted to the character sheet as a pull request on the Roll20 project.

Suggested changes

.ui-dialog .charsheet .pad input,
.ui-dialog .charsheet .pad button,
.ui-dialog .charsheet .pad span,
.ui-dialog .charsheet .pad select,
.ui-dialog .charsheet .pad textarea {
  margin-left: 2px;
  margin-right: 2px;
  margin-bottom: 2px
}
.ui-dialog .charsheet .row-section input[type="checkbox"],
.ui-dialog .charsheet .optionen input {
  width: 30px;
  flex-grow: 0;
}

Git patch file attached.

Effect

Before

Before

After

After

Plushtoast commented 1 year ago

Did you intentionally add the margin-right to all inputs? Or did you only want to add it to checkboxes? I remember I intentionally did not add it to all inputs

LorenzCK commented 1 year ago

I'm not so sure anymore, I might have added it only because I thought it looked better. The only important CSS property is flex-grow: 0 on the checkboxes I think. Feel free to drop the other change.

Another change that I wanted to make, but ultimately failed, is to fix the vertical alignment on the text labels. Like: 217109346-14d9ba59-a7dd-4b64-9ee9-a1d5de410a2c-mod