search

Plushtoast / TDE-Roll20-Official

Das Schwarze Auge / The Dark Eye 5th Ed. System for Roll20
8 stars 2 forks source link

data-i18n key Peitschen is missing in the translation.json file #92

Closed dyvim closed 2 years ago

dyvim commented 3 years ago

the data-i18n key "Peitschen" although present in the html file (line 12396 data-i18n-list-item="Peitschen") is missing in the translation.json file.

can you please add it?

BRgds

dyvim commented 3 years ago

i've found an other key that is missing : data-i18n="MagieundGlaube" (line 1636 and others)

dyvim commented 3 years ago

it could be a good idea to generate a new translation.json file (and make a file compare) a priori only the translation.json has to be redelivered (and not all the separate translation files for each language)

dyvim commented 2 years ago

an other error in the translation.json for the data-i18n key "beidhaendigerkampf", the value is "Beidhändig" when in the html file it is "Beidhändig Kampf" it caused some wrong translations...

Plushtoast commented 2 years ago

See: https://github.com/Roll20/roll20-character-sheets/pull/9802

Plushtoast commented 2 years ago

What's the fuzz about the "Peitschen" key. You requested me to add this. I don't even know why because it's only a list-item

dyvim commented 2 years ago

one key is needed for Peitschen, but not two (lines 472 and 473). I don't care if the key is named "peitschen" or "Peitschen" as long as it is written the same way everywhere (translation.json and html file).

Plushtoast commented 2 years ago

It is already everywhere peitschen except for the data list, but inthis list all ids are uppercase. So it was never a problem.

dyvim commented 2 years ago

and so in the translation.json, you only need one line for peitschen at the moment you have two lines : one with peitschen (l. 473) and one with Peitschen (l. 474). The second one is not needed. That was my point (only that)