search

Plutonomicon / cardano-transaction-lib

A Purescript library for building smart contract transactions on Cardano
https://plutonomicon.github.io/cardano-transaction-lib/
MIT License
92 stars 50 forks source link

`window.cardano.gerowallet` is `undefined` #755

Closed ngua closed 1 year ago

ngua commented 2 years ago

On localhost at least, the Gero wallet browser extension doesn't appear to be injecting the JS API. This isn't a CTL bug, but we should have somewhere to discuss this since there's no open-source repository for the extension

To reproduce:

window.cardano.gerowallet is also undefined when using the dev console directly

klntsky commented 2 years ago

Link to Gero version before the change:

https://github.com/Plutonomicon/cardano-transaction-lib/blob/mike/e2e-simple/test-data/chrome-extensions/gero_testnet_1.10.0_0.crx

I think this guide may be useful to prevent extension updates: https://gist.github.com/juniorcesarabreu/115a4f5141cd1a841119c511c4c66d3f

cyprusdonkey commented 2 years ago

Hi @ngua I believe the issue is with the specific version the manifest is not defined to allow http:/// so that is why you can not see it in localhost. Having said that, there is an offline version we have started working on to accommodate the changes required for Vasil. Its a work in progress but it would be great if you could test it so we can cover as many cases as possible. I can either provide an offline installer or we can push it live in 2-3 days once the current changes have been implemented.

klntsky commented 2 years ago

I can either provide an offline installer or we can push it live in 2-3 days once the current changes have been implemented

@cyprusdonkey that would be great! Where can we get the installer or is the new build already available?

cyprusdonkey commented 2 years ago

Hi @klntsky I will ping you as soon as its available on Chrome store.

cyprusdonkey commented 2 years ago

@klntsky & @ngua https://chrome.google.com/webstore/detail/iifeegfcfhlhhnilhfoeihllenamcfgc here is the latest testnet version, http:/// should be open for local testing. Let me know if any issues. Thank you

ngua commented 2 years ago

Thanks @cyprusdonkey!

cyprusdonkey commented 1 year ago

Hi @ngua circling back on this, has the issue been resolved? Need any further assistance? What was the outcome of the compatibility evaluation? Thank you

klntsky commented 1 year ago

@cyprusdonkey Hi, which testnet is this extension for: preview, preprod, or the legacy one?

We are using the build for preview that Shawn sent to us, and cardano.gerowallet is still undefined there (1.10.15)

klntsky commented 1 year ago

They fixed it