search

Pmmlabs / OpenPeriscope

Unofficial Periscope client
GNU General Public License v2.0
74 stars 30 forks source link

Changed shared by username to link, added style to follow button #113

Closed gitnew2018 closed 6 years ago

gitnew2018 commented 6 years ago

Changed "on channel" to "on:" to make it take less space. Clicking on user that shared a broadcast now takes you to his profile. Channel name and shared by user Show emoticons. Added some color to follow button to make it easier to quickly recognize if you are following this profile, especially on followers list.

Pmmlabs commented 6 years ago

Thanks, but I can't merge your PR because it contains no changes. You merged something, then reverted... Please, do 1 commit for 1 branch, and then from this branch do PR. Now I've cherry-picked your first commit in my "master" branch, changed color of "following" button, refactored your code a bit, so PR is accepted.

gitnew2018 commented 6 years ago

Thanks, I'm new to github and beginner in programming as well. I'm working on some other changes/additions for this project, I hope you don't mind it.

Pmmlabs commented 6 years ago

Of course, and it would be better if you can fix some bugs from issues