search

PnGuadeloupe / db-style-manager

Improve the workflow for managing styles in PostgreSQL
1 stars 2 forks source link

Qgis3 Support #1

Closed RemiDesgrange closed 5 years ago

RemiDesgrange commented 6 years ago

Great Work !!!

I can try making it work with qgis3, maybe a qgis3 Branch ? Can I submit a PR ?

Gustry commented 6 years ago

Thanks for your feedbacks.

Actually, the plugin is only version 0.1 and I still have some development on the plugin. So if we start forking it now, we will have to maintain two versions. And in our organization, we are still using QGIS 2. So the work on QGIS 3 is not our priority now. But no problem, I'm creating the branch now, wait a few minutes. Then I will release a the plugin when needed.

I got some issues, because it's not so easy to have really the same styles between QGIS Desktop and PostGIS.

I'm planning some work in QGIS 3.2 and QGIS 3.4 about managing styles in DB: https://github.com/qgis/QGIS/pull/6968 and https://github.com/qgis/QGIS/pull/7172

Gustry commented 6 years ago

I created a branch if you want to work on it

RemiDesgrange commented 6 years ago

I started porting stuff, does the Makefile work with qgis2 ? it doesn't seems so, but i'm really not an expert in Makefile

Gustry commented 6 years ago

As far as I know, there isn't any command needed for the plugin in the makefile right now. The plugin is not using QtResources etc.

We should make the plugin working for 3.2, as 3.0 is already "end of life". So we can use this new signal: https://qgis.org/api/classQgsProject.html#a5464634d99f8703bc69d6a9846ccbe50 which is important to avoid loading styles which are already loaded in a project

Gustry commented 5 years ago

For now the plugin is still in one file only, so I decided to use a single version of the plugin with compatibility for both QGIS 2 and 3 at the same time. I know this is not the best option for code readability but it's still fine because it's one file only. I will merge the PR after more testing.

I will drop every IF QGIS version 2 statement later in February 2019 when QGIS 2 won't be supported anymore.

RemiDesgrange commented 5 years ago

Sorry to not have looked into this. These days are pretty busy.

Gustry commented 5 years ago

No problem !