search

PnX-SI / gn_mobile_occtax

Application mobile pour la saisie dans le module Occtax de GeoNature
GNU General Public License v3.0
13 stars 5 forks source link

F-Droid inclusion #134

Open IzzySoft opened 2 years ago

IzzySoft commented 2 years ago

Someone anonymously requested to have your app included with F-Droid – but then magically disappeared. So as one of the F-Droid maintainers, I'm carrying this request over to you:

Thanks in advance – and of course you're welcome to chime in to the linked issue directly :wink:

IzzySoft commented 2 years ago

@camillemonchicourt the app is not only connecting to GeoNature instances. Can you please check the list of network connections here? No questions about openstreetmap.org, openseamap.org – and opentopomap.org is probably FOSS, too. But what is e.g. thunderforest.com, wmflabs.org, cloudmade.com, mapbox.com and virtualearth.net – are they all running on FOSS?

@sgrimault thanks! I guess your changes are not yet merged, as I still only see the generic flavor? Can you please let us know which flavor when it's tagged (as we build from tags) – or if you want to let our IssueBot have a test-run before tagging, which commit to point it to?

licaon-kter commented 2 years ago

Can anyone sign and test the latest version? https://gitlab.com/fdroid/fdroiddata/-/jobs/3122499434/artifacts/raw/unsigned/fr.geonature.occtax2_3090.apk

We can merge if you give the ok

sgrimault commented 2 years ago

@licaon-kter , You can find the signed version here: fr.geonature.occtax2.tar.gz @camillemonchicourt or @DonovanMaillard if you ever have some time to test a little. For my part, nothing to report.

linsui commented 1 year ago

@sgrimault The apk can be built reproducibly so we can publish your apk directly. The remain problem is that the tag name, version name and apk url make it can't be updated automatically. We can only fetch the version name with regex but the version name is calculate from the version code. Another problem is that there is a time stamp in the apk but we can't get it when we build the apk.

For the version name, the easist solution is removing the suffix, i.e. 3090. For the time stamp, you can either remove it or publish it along with the apk so that we can fetch it.

Thanks!

IzzySoft commented 1 year ago

@sgrimault any news on this? The merge request is pending your response.

sgrimault commented 1 year ago

@IzzySoft, The timestamp is used to display the version date of the current build in the application parameters.

sgrimault commented 1 year ago

I can remove the suffix if necessary. It's just to make it easier to set up the APKs on the GeoNature side.

licaon-kter commented 1 year ago

Closed as fixed?

IzzySoft commented 1 year ago

I can remove the suffix if necessary. It's just to make it easier to set up the APKs on the GeoNature side.

It just makes it impossible to have auto-updates at F-Droid then – if versionName in build.gradle is not identical to the resulting versionName, builds at F-Droid will fail.

IzzySoft commented 1 year ago

Looks like your build recipe appends the versionCode to versionName in the resulting APK. That's neither indicated in the build.gradle, nor reflected by the tag name or the attached file. So auto-updates at F-Droid will fail, and the reproducible builds as well as the binary (your APK to compare against and to finally ship) cannot be found.

Mind to NOT append that, @DonovanMaillard / @sgrimault ? It only causes confusion and "trouble".

licaon-kter commented 1 year ago

Wow so it's only some text that blocks this? https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11373#note_1537098578

Surely this non-repro stuff can be removed from the APK :+1: