PneumatiCraft / OpenWarp

Teleportation plugin for Minecraft
http://openwarp.lithium3141.com
5 stars 1 forks source link

Warp Database Munging #26

Closed nvx closed 13 years ago

nvx commented 13 years ago

If the warps.yml file fails to be loaded for whatever reason (Issues #22 and #25 for example) warps.yml on disk usually ends up being munged.

A fix for this, and allowing warps.yml to be less volatile would be to only update warps.yml when a warp is added or removed rather than, well, all the time, and when updating, only add/remove that relevant yaml node, rather than regenerating the entire file from the loaded configuration.

timothyekl commented 13 years ago

@nvx: This fix takes out a lot of the warps.yml write instances; however, it doesn't remove them all, and it doesn't yet completely prevent writing an empty warps.yml file (since I don't track whether it's necessary to do a full write on plugin disable). Nevertheless, give it a shot and let me know if things improve. (Should be build 105 in Jenkins.)

timothyekl commented 13 years ago

Closing for now based on @nvx's tentatively positive report; please reopen if this issue resurfaces.