PneumatiCraft / OpenWarp

Teleportation plugin for Minecraft
http://openwarp.lithium3141.com
5 stars 1 forks source link

Question about openwarp.warp.delete permission #35

Closed sql-sith closed 13 years ago

sql-sith commented 13 years ago

Would it be possible (or is it already possible) to allow a user to delete their own warps only? Unless I tested incorrectly, it looks like the openwarp.warp.delete permission allows a user to delete both their own warps and public warps.

I have set quotas so that each player can create 5 private warps and 1 public warp. I would like for my moderators and ops (only) to be able to delete the public warps (or to let players delete only the public warps they themselves have created, since the public warps have an owner: attribute). However, I still want to let regular players delete their own private warps. Is that possible?

Thanks much! This is a really good plugin.

sql-sith commented 13 years ago

Not meaning to nag, but can you comment on this? Maybe I need to take away people's ability to make public warps, but I want the moderators to be able to build truly public warps (for example, a town hall that is not at the spawn). If I give players the delete perm, then they can delete public warps created by others. Is that intentional? It's a show-stopper, because it means that I can't allow players to have the delete perm. This in turn means that they can't delete their own warps, so they need to re-assign them. However, once they get up to their quota, when they try to reassign their warps, they get the message that they are already at their quota.

So, the bottom line is that players are creating warps up to their quota limit and then are unable to delete or reassign them. Like I said, this is a show-stopper for us at the moment. I know you may not have tons of free time to code a fix, but do you have any suggestions for workarounds? Thanks (again)...

timothyekl commented 13 years ago

Sorry about the delay in response!

I believe the "unable to reassign" issue was closed a little while ago - the fix should have made it into recent OpenWarp builds (e.g. 115), which you should now be able to run.

I believe this behavior is by design, as a public warp is truly meant to be public in every sense, including deletion. Check the warp reassignment on the latest builds, and if that works, there's your workaround; a potential solution would be to introduce a new set of permissions governing deletion more granularly, e.g.:

Would that be an acceptable workaround/solution pair? The permissions implementation probably wouldn't happen for a week or so, so if there's a problem with the workaround, let me know.

sql-sith commented 13 years ago

I would be very happy if you could have openwarp.warp.delete.(self|public|others). I will take a look at the workaround soon (maybe not tonight, sorry), because I don't know about the warp reassignment feature.

sql-sith commented 13 years ago

I did take a quick look tonight after all, but couldn't find "warp reassignment." I did see warp sharing, but I don't think that's the same thing. Can you point me to the right place on forums.bukkit.org / dev.bukkit.org / github.com to learn about this?

timothyekl commented 13 years ago

Warp reassignments simply let users move a warp that already exists by reusing the /warp set command. For example, this sequence of actions:

  1. /warp set mywarp
  2. Move ten blocks
  3. /warp set mywarp

should result in a message "Moved private warp mywarp." This is what I mean when I say 'reassignment' - you can deny users the delete permission and still allow them to move existing warps. (Note this has the unfortunate implication that warp names are immutable once created - I still think the best solution will be for me to implement specific delete permissions, but this may tide you over until then.)

Nichts commented 13 years ago

i would really appreciate specific delete permissions

timothyekl commented 13 years ago

@chris-leonard, @Nichts: closed as of build 127. Sorry about the long delay, and I hope this works for you guys. (See the commit message for the details; I'll also be updating the wiki soon.)

sql-sith commented 13 years ago

Thank you!!! Will test soon (not tonight but maybe tomorrow). You rock!