PoE-Overlay-Community / PoE-Overlay-Community-Fork

An Overlay for Path of Exile. Built with Angular.

MIT License

459 stars 84 forks source link

Multiple Windows Trades Tool Not Saving Position #226

Open garaile opened 3 years ago

garaile commented 3 years ago

May be related to issue #186 but felt different so I opened this. If it is the same just close it.

🐞 bug report

Describe the bug The Trades Companion feature is not on the correct screen and I cannot get it to save its position after the reset button is pressed.

To Reproduce

Expected behavior It to save where I move it like it does before I press the "Reset" button. Also may be related but the default it moves to is another window then Path of exile is on so not sure if related.

Screenshots

🌍 Your Environment

OS: Win 10 x64
Version: 0.8.1 both installed and standalone
PoE: Original Client 3.14.3b
Multiple Windows

WhiteFang5 commented 3 years ago

Am I correct your reproduction is as following?:

Open/launch poe-overlay
Enable trade companion in the settings (and save/close settings window)
Unlock the trace companion bar
Move the bar to the desired position
(optionally) lock the bar again
Exit/close poe-overlay
(re)launch poe-overlay
bar position is now reset?

garaile commented 3 years ago

Almost. After you

Enable trade companion in the settings (and save/close settings window)
Reopen settings
Press "reset" button next to the enable trade companion button.
move the window
Press settings icon on the trade companion or f7
Close the settings and the trades companion moves to default position.

If I delete the appdata folder and rerun the app it works as normal (indented) until I press the reset button once. After which it fails to work until I clear the AppData folder again. Edit: formatting + wording

WhiteFang5 commented 3 years ago

Thanks for the additional info. It appears to be an issue with the reset button (based on the additional info). We'll look into it.

melink14 commented 2 years ago

Also experienced this bug; is there any reason to hit the reset button? I guess it's okay if I avoid hitting it at all. (I only have one monitor though; so it looks like that's not a factor)

TacticalMook commented 2 years ago

Rather than related to the reset button, I believe the issue is the window position is not being saved.

My companion window was returning to the same non-default position with every start, restart, and whenever the settings window was opened.

Hitting the reset button did work, and but now it's simply resetting to the default position with every start, restart, and whenever the settings window is opened.

It seems to me like the window position is not being saved to file, with the exception of hitting reset button.