PoE-Overlay-Community / PoE-Overlay-Community-Fork

An Overlay for Path of Exile. Built with Angular.
MIT License
460 stars 83 forks source link

Trade Companion improvements - round 2 #238

Open fatings opened 3 years ago

fatings commented 3 years ago

Trade Companion feedback - round 2

Features

  1. New (optional) button in trade bar to copy item name to clipboard (maybe an option as well to auto copy item name to clipboard on incoming message).
  2. Option to monitor the clipboard for new outgoing messages and send them automatically ingame. (Allow a keybind for this, so it's not always on). Example: Assuming keybind for CTRL, pressing CTRL+Click on the Whisper message in the PoE Trade website, the app would focus the PoE window and send the message.
  3. Option to hide the interface when there's no trade available
  4. Option to NOT hide the interface when POE is out of focus

Bugs

  1. Grid sometimes doesn't go away automatically after clicking the T (trade) button.
  2. Trade box sometimes doesn't go away when clicking "thx" button.
  3. Incoming trades sometimes don't register with the trade companion.

Visual aid of two separate occurrences for bug number 3: 2021-07-27 12_12_20-Path of Exile 2021-07-27 12_49_02-Path of Exile

WhiteFang5 commented 3 years ago

Thanks once more for the suggestions. We'll look into them and see which ones can be implemented.

Regarding your 3rd bug: Incoming trades sometimes don't register with the trade companion.
This is unfortunately something we cannot fix at all. Any player that use the Korean client to play, won't have their trade messages logged in the client.txt (the file we monitor for incoming trade messages) due to Korean laws.

fatings commented 3 years ago

oh yeah, I forgot that Korean privacy was a thing (playing too much SSF ^_^). Thanks again, was in auto-pilot mode and didn't even thanked you for all the good work.

Keep it going. Best regards.

Reithan commented 3 years ago

Possible additional thing to add to this request (or a different request?)

WhiteFang5 commented 2 years ago

@Reithan thanks for this additional suggestion. I've looked into this and placeholders @item and @price will be usable for the custom trade buttons' messages in the next release.

@fatings I've looked at some of your other suggestions and was wondering if you have any further suggestions on how they would work practically:

Option to hide the interface when there's no trade available

How would you go about moving the bar then? Only when you get a message it can be moved? Probably one could also create a test message to then move it, but that poses some other difficulties in terms of communication between the main app (where the bar is located) and the settings window (from where you create/add these test messages)

Option to monitor the clipboard for new outgoing messages and send them automatically ingame.

This one is going against the ToS as it automates a functionality. i.e. auto-pasted & sending whispers based on clipboard data isn't really allowed. The best we could do it provide a shortcut-key to "paste and send" the message once you're in the game again; but that kinda defeats the purpose, since you could simply CTRL+V anyway.

fatings commented 2 years ago

Hey @WhiteFang5, regarding the

Option to hide the interface when there's no trade available

I would say the interface should always be visible while settings are open. In addition to this, I'd create a checkbox in settings to enable the auto hide feature.

Other topic I think could be improved are the buttons from the main interface moving inside the bar. What happens now is that when you close the last trade available and want to go to your hideout, the hideout button (and others) move place. Example below: image image