PoE-Overlay-Community / PoE-Overlay-Community-Fork

An Overlay for Path of Exile. Built with Angular.
MIT License
460 stars 85 forks source link

Improve copying price strings for bulk items #306

Open daviderickson opened 2 years ago

daviderickson commented 2 years ago

When using the evaluate module and clicking on another person's price listing to copy the price, if the price is a fraction it currently copies as a decimal number, ie: 0.125. However if you list it as such, listing services will round it to 0.5. Further, depending on the fraction, it can be hard to reason about as a user on how many that really represents per unit of currency.

This patch modifies the copied text to instead contain the pervasive fractional numerator/denominator formatting for any price that has a denominator greater than 1.

Description

Replication Steps

  1. ctl-D on a bulk currency item
  2. Find a listing that is a fraction
  3. Click the listing
  4. You should now get pricing text with a fraction ie X/Y rather than .025

Screenshots/Video

How Has This Been Tested?