PoE-Overlay-Community / PoE-Overlay-Community-Fork

An Overlay for Path of Exile. Built with Angular.
MIT License
460 stars 85 forks source link

Suggestion: selectable language to send or receive message for trade companion #326

Open archanfel777 opened 1 year ago

archanfel777 commented 1 year ago

๐Ÿš€ feature request

Is your feature request related to a problem? Please describe. Hello I am using the English client of GGG headquarters, but the game language is Korean.

The messages sent and received during transactions are in Korean, but the trade companion does not work because it does not recognize them. However, it works fine when sending or receiving messages in English.

It is presumed that only English messages are recognized because PoE-Overlay's webpage was logged in in English, the PoE client is in English, or my PoE account belongs to GGG, which is based on English.

Actually, since the transaction message is the same as the in game language with a high probability, it is reasonable to determine that the language detected for the trade companion to operate is the same as the Game settings - Language(in game language) set in PoE-Overlay.

If possible, could you please reflect the changes regarding this? Thank you for always providing great features.

I've checked the notification code and realized that it was checking all language texts and that the Korean texts have changed since 3.21. I tried to make PR by directly modifying the Korean text, but it failed with an unknown error So the Korean field that needs to be modified in trade-regexes.json is posted here. Hopefully this text fix will be merged.

joinedArea.Korean : ": (?.*?) ๋‹˜์ด ์ง€์—ญ์— ๋“ค์–ด์™”์Šต๋‹ˆ๋‹ค\.?"

leftArea.Korean : ": (?.*?) ๋‹˜์ด ์ง€์—ญ์—์„œ ๋‚˜๊ฐ”์Šต๋‹ˆ๋‹ค\.?"

tradeItemPrice.Korean : "^์•ˆ๋…•ํ•˜์„ธ์š”, (?\d([.|,]\d)?) (?.)\(์œผ\)๋กœ ์˜ฌ๋ ค๋†“์€ (?.) ๋ฆฌ๊ทธ์˜ (?.)\(์„\)๋ฅผ ๊ตฌ๋งคํ•˜๊ณ  ์‹ถ์Šต๋‹ˆ๋‹ค \(๋ณด๊ด€ํ•จ ํƒญ \\"(?.)\\", ์œ„์น˜: ์™ผ์ชฝ (?\d), ์ƒ๋‹จ (?\d)\)(?.*)?"

tradeItemNoPrice.Korean : "^์•ˆ๋…•ํ•˜์„ธ์š”, (?.) ๋ฆฌ๊ทธ์˜ (?.)\(์„\)๋ฅผ ๊ตฌ๋งคํ•˜๊ณ  ์‹ถ์Šต๋‹ˆ๋‹ค \(๋ณด๊ด€ํ•จ ํƒญ \\"(?.)\\", ์œ„์น˜: ์™ผ์ชฝ (?\d), ์ƒ๋‹จ (?\d)\)(?.)?"

tradeBulk.Korean : "^์•ˆ๋…•ํ•˜์„ธ์š”, (?.) ๋ฆฌ๊ทธ์˜ (?\d) (?.)\(์„\)๋ฅผ (?\d([.|,]\d)?) (?.)\(์œผ\)๋กœ ๊ตฌ๋งคํ•˜๊ณ  ์‹ถ์Šต๋‹ˆ๋‹ค\.?(?.*)?"

Thx for your support.

Describe the solution you'd like Making the trade companion's action trigger message language the same as the PoE-Overlay's Game settings - Language

Describe alternatives you've considered

Additional context