Trade Macro Doesn't Respond to Alt+D

Zerfaul commented 3 years ago

Hi. My trademacro doesnt respond to alt+D or any price related keys. When i press to F5 i can go to my hideout or when i press Alt + E it responds. So its working but not responding Alt+D I'm running the game Borderless windowed and got latest AHK and Trademacro. Thanks.

TEMPLATE (Remove the explanations here from your post)

Make sure:

That you have checked the Wiki/FAQ before creating any issue.
That poe.trade/GGG's website don't have any issues if loading the script takes too long or failes.

Information to include:

AHK (including 32/64bit) version if you have any kind of script errors.
Windows version could be relevant.

Fill out everything that may be relevant and remove everything except these informations below:

AHK version:latest Windows version:win10

Eakz commented 3 years ago

I have same issue. Was trying to find the solution. Doesnt respond to anything besides alt+e(which again shows me that "no account name specified in settings menu")...Prices not working at all

derbol commented 3 years ago

Same here, most keybinds don't show anything. When saving the information to the clipboard, I can see, that it does correctly fetch everything, it just doesn't display anything. I reinstalled to ahk 1.33 64 bit, deleted all old trade macro folders and backups, still the same. F5 etc works, is functioning, just not displaying anything most of the time.

Zenthae commented 3 years ago

broken for me too

Uchigatan commented 3 years ago

Bump

Spykerr2842 commented 3 years ago

Same here. F5 works and Alt+E and not much else. Tried reinstalling everything, nothing changed

ATufekovic commented 3 years ago

Bump, same issues as other people, i thought i was crazy for a moment and that i broke something before looking the issue up.

soockee commented 3 years ago

same

Zenthae commented 3 years ago

well, anyway, since it's been month since the last update we probably won't have a fix, time to use something else

arsirantala commented 3 years ago

Same here - doesn't work. Also reinstalled treade macro, but didn't change the expected behavior.

serogich commented 3 years ago

and it doesn't work for me

ba-chan commented 3 years ago

It's not just Alt+D, it seems to be anything that requires parsing of the item text copied from the game client. The format has changed slightly, meaning it can no longer be cut-n-pasted into Path of Building without editing either.

froks commented 3 years ago

Pull Request #1177 should fix at least simple cases

Zenthae commented 3 years ago

if anyone interested, i found this https://github.com/Kyusung4698/PoE-Overlay as an alternative, sadly it depends on Overwolf, but at least it do the job

Zerfaul commented 3 years ago

if anyone interested, i found this https://github.com/Kyusung4698/PoE-Overlay as an alternative, sadly it depends on Overwolf, but at least it do the job

Ah i didn't know this one. Thank you for sharing

serlucian commented 3 years ago

same for me. ald+d not working, just alt+e ;(

Almighty1g commented 3 years ago

Same.

Spykerr2842 commented 3 years ago

if anyone interested, i found this https://github.com/Kyusung4698/PoE-Overlay as an alternative, sadly it depends on Overwolf, but at least it do the job

https://github.com/SnosMe/awakened-poe-trade This is what I'm trying since yesterday. Pretty positive so far

dwiggins5091 commented 3 years ago

bump

xkylieo commented 3 years ago

Theres a fix someone posted elsewhere had to edit some code at Line 7350

leaving my copy of the fixed version if youd like. https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

; ParseItemName fixed by user: uldo_. Thanks! ParseItemName(ItemDataChunk, ByRef ItemName, ByRef ItemBaseName, AffixCount = "", ItemData = "") { isVaalGem := false If (RegExMatch(Trim(ItemData.Parts[1]), "i)\^Rarity: Gem") and RegExMatch(Trim(ItemData.Parts[2]), "i)Vaal")) {

isVaalGem := true

}

If (RegExMatch(ItemData.NamePlate, "i)Rarity\s?+:\s?+(Currency|Divination Card|Gem)", match)) { If (RegExMatch(match1, "i)Gem")) { ItemBaseName := Trim(RegExReplace(ItemName, "i) Support")) } Else {

ItemBaseName := Trim(ItemName)

}
} ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1) ; <----- new

KingKatura commented 3 years ago

Theres a fix someone posted elsewhere had to edit some code at Line 7350

leaving my copy of the fixed version if youd like. https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

; ParseItemName fixed by user: uldo_. Thanks! ParseItemName(ItemDataChunk, ByRef ItemName, ByRef ItemBaseName, AffixCount = "", ItemData = "") { isVaalGem := false If (RegExMatch(Trim(ItemData.Parts[1]), "i)^Rarity: Gem") and RegExMatch(Trim(ItemData.Parts[2]), "i)Vaal")) {
isVaalGem := true
}

If (RegExMatch(ItemData.NamePlate, "i)Rarity\s?+:\s?+(Currency|Divination Card|Gem)", match)) { If (RegExMatch(match1, "i)Gem")) { ItemBaseName := Trim(RegExReplace(ItemName, "i) Support")) } Else {
ItemBaseName := Trim(ItemName)
} } ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1) ; <----- new

hey it works.. drag into poemacro-resources-AHk and overwrite it will work again. Thanks for the fix now the creator needs to update it.

ArensKyle commented 3 years ago

Theres a fix someone posted elsewhere had to edit some code at Line 7350 leaving my copy of the fixed version if youd like. https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0 ; ParseItemName fixed by user: uldo_. Thanks! ParseItemName(ItemDataChunk, ByRef ItemName, ByRef ItemBaseName, AffixCount = "", ItemData = "") { isVaalGem := false If (RegExMatch(Trim(ItemData.Parts[1]), "i)^Rarity: Gem") and RegExMatch(Trim(ItemData.Parts[2]), "i)Vaal")) {
isVaalGem := true
} If (RegExMatch(ItemData.NamePlate, "i)Rarity\s?+:\s?+(Currency|Divination Card|Gem)", match)) { If (RegExMatch(match1, "i)Gem")) { ItemBaseName := Trim(RegExReplace(ItemName, "i) Support")) } Else {
ItemBaseName := Trim(ItemName)
} } ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1) ; <----- new
hey it works.. drag into poemacro-resources-AHk and overwrite it will work again. Thanks for the fix now the creator needs to update it.

Looks like this fixes the basic search functionality, but I'm still unable to run an advanced search on rare items. Anyone have ideas where that might be broken?

ArensKyle commented 3 years ago

Looks like this fixes the basic search functionality, but I'm still unable to run an advanced search on rare items. Anyone have ideas where that might be broken?

Replying to my own comment, it actually looks like the item type parsing is what's busted. Advanced search will still work on weapons, but it only works on weapons. You can hack around it by setting the property "hasAdvancedSearch" to always be true instead of having it actually check. That change is in POE-TradeMacro-2.16.0\resources\ahk\TradeMacro.ahk on line 468.

Nivelm commented 3 years ago

New fix in this post https://github.com/PoE-TradeMacro/POE-TradeMacro/pull/1177#issuecomment-822774321

Just add this line to an original https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk

Now advanced search works.

ba-chan commented 3 years ago

New fix in this post #1177 (comment)

Nice, all my use cases are now functional :-)

CountWiggin commented 3 years ago

@Nivelm : Hi, I'm having trouble fixing TradeMacro using your instructions - if I add that specific line ("https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk") to the file POE-ItemInfo.ahk I get an error while launching, if I get all the code lines from here (https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk) and I add them in the file (have no ideea where to add them) I also get an error while launching, if I get the code lines mentioned above and replace all content in the POE-ItemInfo.ahk I can launch it but advanced search doesn't work. I play Standard league, softcore, windowed.
Can you please explain step-by-step what I need to do in order to make it work ? Tx.

Nivelm commented 3 years ago

@nivlem : Hi, I'm having trouble fixing TradeMacro using your instructions - if I add that specific line ("https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk") to the file POE-ItemInfo.ahk I get an error while launching, if I get all the code lines from here (https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk) and I add them in the file (have no ideea where to add them) I also get an error while launching, if I get the code lines mentioned above and replace all content in the POE-ItemInfo.ahk I can launch it but advanced search doesn't work. I play Standard league, softcore, windowed. Can you please explain step-by-step what I need to do in order to make it work ? Tx.

First of all you need the original file from your installation with no modifications. You can extract and replace it from your downloaded POE-TradeMacro-2.16.0.zip

Go find in your PC where POE-TradeMacro is installed. Folder should be POE-TradeMacro-2.16.0

Inside POE-TradeMacro-2.16.0 folder open resources\ then ahk\

Locate POE-ItemInfo.ahk file

Open it with Notepad

Find this function: PreProcessContents (Menu-Edit-Find)

PreProcessContents(CBContents)
{
; --- Place fixes for data inconsistencies here ---

; Remove the line that indicates an item cannot be used due to missing character stats  
    ; Matches "Rarity: ..." + anything until "--------"\r\n
    If (RegExMatch(CBContents, "s)^(.+?:.+?\r\n)(.+?-{8}\r\n)(.*)", match)) {

Add this new line:

CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1)

Function should look like this with the new added line:

PreProcessContents(CBContents)
{
; --- Place fixes for data inconsistencies here ---
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1) ; <----- new

; Remove the line that indicates an item cannot be used due to missing character stats  
    ; Matches "Rarity: ..." + anything until "--------"\r\n
    If (RegExMatch(CBContents, "s)^(.+?:.+?\r\n)(.+?-{8}\r\n)(.*)", match)) {

Save file and restart POETradeMacro.

nesreb commented 3 years ago

@Nivelm, I edited the file and added the single line of code you suggested. Everything's working so far. Thank you for generously volunteering your time to help your fellow PoE addicts.

CountWiggin commented 3 years ago

@Nivelm : Thank you for helping, it worked !. Have a nice day :)

xkylieo commented 3 years ago

Theres a fix someone posted elsewhere had to edit some code at Line 7350 leaving my copy of the fixed version if youd like. https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0 ; ParseItemName fixed by user: uldo_. Thanks! ParseItemName(ItemDataChunk, ByRef ItemName, ByRef ItemBaseName, AffixCount = "", ItemData = "") { isVaalGem := false If (RegExMatch(Trim(ItemData.Parts[1]), "i)^Rarity: Gem") and RegExMatch(Trim(ItemData.Parts[2]), "i)Vaal")) {
isVaalGem := true
} If (RegExMatch(ItemData.NamePlate, "i)Rarity\s?+:\s?+(Currency|Divination Card|Gem)", match)) { If (RegExMatch(match1, "i)Gem")) { ItemBaseName := Trim(RegExReplace(ItemName, "i) Support")) } Else {
ItemBaseName := Trim(ItemName)
} } ItemDataChunk := SubStr(ItemDataChunk, InStr(ItemDataChunk,"`n") + 1) ; <----- new
hey it works.. drag into poemacro-resources-AHk and overwrite it will work again. Thanks for the fix now the creator needs to update it.
Looks like this fixes the basic search functionality, but I'm still unable to run an advanced search on rare items. Anyone have ideas where that might be broken?

Fixed now new download link https://www.dropbox.com/s/l2qlh4vppwbs06l/POE-ItemInfo.ahk?dl=0

Herbie-pat commented 3 years ago

Just made an account to say you: Thank you for your excellent work! I also got worried what could have gone wrong and i often have my issues with diving into solving problems like this. I also want to thank you in behalf of my friends who also use this tool and don't have to worry and just add the script line and enjoy playing <3

MorbiusProductions commented 3 years ago

@nivlem : Hi, I'm having trouble fixing TradeMacro using your instructions - if I add that specific line ("https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk") to the file POE-ItemInfo.ahk I get an error while launching, if I get all the code lines from here (https://github.com/PoE-TradeMacro/POE-TradeMacro/blob/eb20d12d1dc875c0bde6731d8b8193031309bffa/resources/ahk/POE-ItemInfo.ahk) and I add them in the file (have no ideea where to add them) I also get an error while launching, if I get the code lines mentioned above and replace all content in the POE-ItemInfo.ahk I can launch it but advanced search doesn't work. I play Standard league, softcore, windowed. Can you please explain step-by-step what I need to do in order to make it work ? Tx.

First of all you need the original file from your installation with no modifications. You can extract and replace it from your downloaded POE-TradeMacro-2.16.0.zip

Go find in your PC where POE-TradeMacro is installed. Folder should be POE-TradeMacro-2.16.0

Inside POE-TradeMacro-2.16.0 folder open resources\ then ahk\

Locate POE-ItemInfo.ahk file

Open it with Notepad

Find this function: PreProcessContents (Menu-Edit-Find)
PreProcessContents(CBContents)
{
; --- Place fixes for data inconsistencies here ---

; Remove the line that indicates an item cannot be used due to missing character stats    
  ; Matches "Rarity: ..." + anything until "--------"\r\n
  If (RegExMatch(CBContents, "s)^(.+?:.+?\r\n)(.+?-{8}\r\n)(.*)", match)) {
Add this new line:
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1) 
Function should look like this with the new added line:
PreProcessContents(CBContents)
{
; --- Place fixes for data inconsistencies here ---
CBContents:= SubStr(CBContents, InStr(CBContents,"`n") + 1) ; <----- new

; Remove the line that indicates an item cannot be used due to missing character stats    
  ; Matches "Rarity: ..." + anything until "--------"\r\n
  If (RegExMatch(CBContents, "s)^(.+?:.+?\r\n)(.+?-{8}\r\n)(.*)", match)) {
Save file and restart POETradeMacro.

This worked for me. The other fix didn't.

TridentRPG commented 3 years ago

This worked for me. The other fix didn't.

Worked for me, as well!

regara commented 3 years ago

Also worked for me

Emphasis on needing to restart it after

TonZaga commented 3 years ago

TL:DR - I'm getting a ParseMapTier: couldn't parse item data chunk when I try to Alt+D in game.

louisphilipj commented 3 years ago

PoE-TradeMacro / POE-TradeMacro

Trade Macro Doesn't Respond to Alt+D #1176