search

PoE-TradeMacro / POE-TradeMacro

Price checking script for Path of Exile.
https://poe-trademacro.github.io/
GNU General Public License v3.0
937 stars 189 forks source link

Improving the PoePrices dialogue #696

Closed nijikokun closed 6 years ago

nijikokun commented 6 years ago

I changed the dialogue for the PoePrices, It's a little rough but it adds what I wanted which is the "Recommended" price by parsing the HTML:

pathofexile_x64_2018-03-25_17-13-23

I also removed the feedback ui because i never use it. would be cool to have a setting.

Here is the code changes:

https://gist.github.com/nijikokun/59e714dac3fccc0e691ecff18eb75b9f

If you use it or find inspiration that's cool, I was thinking about making a PR but I can probably just copy paste these on update so I'm not sure I will.

Eruyome commented 6 years ago

I've talked with the peoprices devs, well one of them, about the recommended price before. It's something that may not be there to stay. It also needs a different/second server request to get this price, therefore we decided that I shouldn't include it.

About the feedback UI, it would be a bit unfair to remove it or add an option for that. They need support to keep their serves going and they need feedback to improve their predictions. I believe both UI parts are seperated clear enough so that the feedback part can be easily ignored.

I'm not saying we can't talk about including more information but I don't want to simply scrape their html instead of finding a solution together with them.

nijikokun commented 6 years ago

I don't care enough, about this, to argue or debate about whether they need support, whether the feedback UI gives them that support, or whether scraping is a the right solution for them, considering the tool does it in other locations for other services.

As a note, I've completely stopped using the feedback ui in favor of the tooltip, it's faster. https://gist.github.com/nijikokun/59e714dac3fccc0e691ecff18eb75b9f#file-parsepoepricesinfodata-ahk

If someone wants to do this, the above is there, that's how it's done.

Eruyome commented 6 years ago

TradeMacro only scrapes services that can handle it though, the poeprices servers "died" a few times in the past already and were offline for a few hours because they couldn't handle the requests, most of them coming from TradeMacro, so I tend to be careful about that.