PoE-TradeMacro / POE-TradeMacro

Price checking script for Path of Exile.
https://poe-trademacro.github.io/
GNU General Public License v3.0
936 stars 188 forks source link

Price checking some items causes Memory Error #840

Closed jan-car closed 4 years ago

jan-car commented 5 years ago

For some items (e.g. Abyss Jewels, some uniques, rarely for rares), when trying to price check with ctrl+D "requesting search results" pops up, but nothing happens afterwards. Scrolling through tabs still works and I can change league, but price checking doesn't even pop up the info box anymore. After several minutes, this error pops up:

capture

I'm on Windows 10 / 64bit with AHK v1.1.30.01 and I'm using v2.12.2 of POE-TradeMacro, but this happens since a few releases (mid Delve, I think).

Eruyome commented 5 years ago

Can you check whether there was any windows update installed at the time where this started to happen?

jan-car commented 5 years ago

Yes, there were the following updates during Delve (can't say for sure when exactly the issue started happening):

October: https://support.microsoft.com/en-us/help/4462918/windows-10-update-kb4462918 November: https://support.microsoft.com/en-us/help/4467686/windows-10-update-kb4467686

Anything I have to look for?

Is there a way to access a log of some kind?

Eruyome commented 5 years ago

I don't really know but you wouldn't be the first to have issues with AHK/TradeMacro because of some win10 Update, whether this is the case here I can't say.

(Accidentaly closed the issue)

Eruyome commented 5 years ago

Any update on this?Still don't really know what to test/check...

jan-car commented 5 years ago

It still happens (updated to the current version, but, mainly for magic items (like Abyss Jewels) and for some Gems and Uniques. If it happens, it seems to be reproducible (crashes for the same items again if I try immediately after restarting the script), so I think it does not depend on the number of items I check. Rares and their price prediction work fine all the time.

Didn't play around with the new "Curl/HTTP request timeout" option, but I assume that should not be connected to the issue, right?

If there is a log file I can provide, please let me know where I can find it.

Eruyome commented 5 years ago

That option is not relevant.

You said it happens with certain items, can you post their data here? ctrl +c ingame to copy that to your clipboard.

jan-car commented 5 years ago

I won't be able to play until tomorrow evening, I think, but I'll collect a few examples as soon as I can!

jan-car commented 5 years ago

Found some time today to test stuff, worked much better than the last days though.

One example for magic Abyss Jewels:

Rarity: Magic
Incandescent Ghastly Eye Jewel of Marshalling
--------
Abyss
--------
Requirements:
Level: 60
--------
Item Level: 83
--------
+42 to maximum Energy Shield
Minions deal 37% increased Damage against Abyssal Monsters
--------
Place into an Abyssal Socket on an Item or into an allocated Jewel Socket on the Passive Skill Tree. Right click to remove from the Socket.

It did work when it only had the maximum Energy Shield, after augmenting the Damage, I got the aforementioned error. After restarting and regaling, it did work again (as mentioned it does with all Rares).

Does not work with Resonators of all kinds, e.g.:

Rarity: Currency
Prime Chaotic Resonator
--------
Requires 4 Socketed Fossils
--------
Sockets: D D D D 
--------
Reforges a rare item with new random modifiers
--------
All sockets must be filled with Fossils before this item can be used.

Same deal with Fossils, e.g.:

Rarity: Currency
Jagged Fossil
--------
More Physical modifiers
No Chaos modifiers
--------
Place in a Resonator to influence item crafting.

Some Uniques don't work too:

The Restless Ward
Carnal Armour
--------
Evasion Rating: 1236 (augmented)
Energy Shield: 343 (augmented)
--------
Requirements:
Level: 71
Dex: 88
Int: 122
--------
Sockets: R 
--------
Item Level: 72
--------
6% increased maximum Life
--------
250% increased Evasion and Energy Shield
+78 to maximum Life
1% increased Movement Speed per Frenzy Charge
25.2 Life Regenerated per second per Endurance Charge
100% increased Endurance, Frenzy and Power Charge Duration
--------
Use the dead to stave off death,
An armour of bones and rot.
Hanging on with bated breath,
One lapse and all for naught.
--------
Corrupted

Possibly, because of the corruption? Bought an uncorrupted one to test and it indeed worked:

Rarity: Unique
The Restless Ward
Carnal Armour
--------
Evasion Rating: 1211 (augmented)
Energy Shield: 336 (augmented)
--------
Requirements:
Level: 71
Dex: 88
Int: 122
--------
Sockets: G-B 
--------
Item Level: 72
--------
+25 to maximum Mana
--------
243% increased Evasion and Energy Shield
+77 to maximum Life
1% increased Movement Speed per Frenzy Charge
22.4 Life Regenerated per second per Endurance Charge
100% increased Endurance, Frenzy and Power Charge Duration
--------
Use the dead to stave off death,
An armour of bones and rot.
Hanging on with bated breath,
One lapse and all for naught.

However, not all Unique corruptions cause an error, the following e.g. works:

Rarity: Unique
Araku Tiki
Coral Amulet
--------
Item Level: 75
--------
5% Chance to Block Spell Damage
--------
+100 to Evasion Rating while on Low Life
+45 to maximum Life
+24% to Fire Resistance
1% of Life Regenerated per second while on Low Life
--------
It is said to make you invisible when the Great
Spirit comes to take you on your final journey.
--------
Corrupted

Some uncorrupted Uniques don't work as well, e.g.:

Rarity: Unique
Balefire
Opal Sceptre
--------
One Handed Mace
Quality: +20% (augmented)
Physical Damage: 59-88 (augmented)
Critical Strike Chance: 6.50%
Attacks per Second: 1.25
Weapon Range: 9
--------
Requirements:
Level: 60
Str: 95
Int: 131
--------
Sockets: B B 
--------
Item Level: 82
--------
40% increased Elemental Damage
--------
Grants Level 25 Scorching Ray Skill
20% increased Cast Speed
Recover 1% of Maximum Life on Kill
Recover 2% of Maximum Mana on Kill
10% increased Scorching Ray beam length
--------
After the fires swept down from the sky and swallowed the city,
all that lingered, as if locked in time,
was a memory of that which was gone, a whisper of deeds undone.

Most Skill Gems work, but some don't, e.g.:

Rarity: Gem
Blood Magic Support
--------
Support
Level: 20 (Max)
Mana Multiplier: 196%
Quality: +20% (augmented)
--------
Requirements:
Level: 70
Str: 111
--------
Supports any skill.
--------
Supported Skills have 10% reduced Mana Cost
Supported Skills Spend Life instead of Mana
--------
This is a Support Gem. It does not grant a bonus to your character, but to skills in sockets connected to it. Place into an item socket connected to a socket containing the Active Skill Gem you wish to augment. Right click to remove from a socket.

Last but not least, Wisdom Scroll don't work too....

Rarity: Currency
Scroll of Wisdom
--------
Stack Size: 1/40
--------
Identifies an item
--------
Right click this item then left click an unidentified item to apply it.

Hope this helps, it seems rather arbitrary to me, to be honest.

Eruyome commented 5 years ago

This seems really random to me. Since you're pretty much the only person to report this issue I'd guess it's an issue with your system, not AHK specificially. There isn't much to find where people talk about MaxMem issues, try reading this though if you want. I don't think that I've fallen in any of the "traps", which would be obvious since more people would have that issue.

BUT that doesn't meant that we are completely out of options. The #MaxMem command

Sets the maximum capacity of each variable to the specified number of megabytes.

according to the documentation, where the default is 64 megabytes, which should be overkill already.

Try opening resources\ahk\TradeMacoInit.ahk in a text editor and add the MaxMem command at the beginning:

#SingleInstance force
#NoEnv ; Recommended for performance and compatibility with future AutoHotkey releases.
#Persistent ; Stay open in background
#MaxMem, 128

should look like this. Try playing around with the value (in megabytes) and see if it helps.

Eruyome commented 4 years ago

Closed because the issue is so old. Feel free to message again if the issues still persist.