search

PoE-TradeMacro / POE-TradeMacro

Price checking script for Path of Exile.
https://poe-trademacro.github.io/
GNU General Public License v3.0
936 stars 188 forks source link

Restrict leagues when cycling with Ctrl+L #955

Open Irfy opened 5 years ago

Irfy commented 5 years ago

(This is an improvemet/feature request, not an issue)

I have this long-standing issue with Ctrl+L: it cycles through leagues that I have zero interest in. Come to think of it, the vast majority of people either plays hardcore or softcore at a time -- so the vast majority of people will be interested in cycling only through a subset of available leagues.

Changing leagues is not an instant operation, and it can get annoying when trading in two leagues and price checking offers: Ctrl+L, wait, Ctrl+L, wait, check price, Ctrl+L, wait, Ctrl+L, wait -- in order to check a price and return back to main league (in the case of standard -> hardcore -> tmpstandard -> tmphardcore sequence -- add two more [Ctrl+L, wait] if an event league is ongoing).

I propose to implement a configuration option, (possibly without GUI, just in the config file), that lists leagues (by key) that we are interested in cycling in with Ctrl+L. By default (empty config variable), the behavior of Ctrl+L is unchanged.

So for example, if I'm only interested in the current softcore challenge league and, if-existent, the current softcore event league, I would define a variable like:

AllowedSearchLeagues = tmpstandard,eventstandard

(assuming I got the key names right).

This list would then be consulted in the TradeFunc_ChangeLeague code, so that the next selected league is guaranteed to be one of those listed in the variable (with graceful handling of bogus list contents).

I'll be committing an attempt at implementing this and will reference this issue, for your review and feedback.

(Trying to implement a solution to this issue motivated the PR #953, where I clean up existing code, without any semantic changes)

Eruyome commented 5 years ago

Should I implement this I'd rather add checkboxes on the UI to ex-/inlcude SSF/hc/sc.