search

PoGo-Devs / PoGo

UWP Client for Pokemon Go
https://pogo-windows.com/
MIT License
38 stars 9 forks source link

API needs to buffer Geolocation changes between requests #31

Open robertmclaws opened 8 years ago

robertmclaws commented 8 years ago

I'm not sure if the Signature code is doing this right now, but the real game samples GPS location every second, and stores it in a buffer to be sent the next time GetMapObjects is called. We need to do the same thing, either at the ApiClient or GameService level.

WallyCZ commented 8 years ago

It's already done in DeviceInfo (PokemonGo_UWP.Utils.DeviceInfosIOS) class in main app. I don't think that Api should collect it, it is responsibility of the app. And if we want emulate more devices, this needs to stay in this DeviceInfo class, because these data are different on different devices.

robertmclaws commented 8 years ago

Having started to import the existing DeviceInfo code to the new GameServices, it is pulling info directly from the legacy GameClient class, which is not going to be possible moving forward. The relevant code will need to be moved to the new LocationService, which will combine buffer the location data until it is ready to be dumped into the Signature.