search

Pocket-Plane-Group / Lure_Of_Sirines_Call

Adds a quest - and pirates! - to the sirines and the southern part of the lighthouse map
https://www.pocketplane.net/bg1tutu-enhancements/
4 stars 6 forks source link

The mod needs to be installed before EET_End #6

Closed Roberciiik closed 3 years ago

Roberciiik commented 3 years ago

I think I found a typo. Based on tp2 script, this mod should be installed before EET_End, but translations say "after". There is a possibility that installation script is wrong and mod should be installed after EET_End. Please verify.

Roberciiik commented 3 years ago

Waiting for previous PR to be merged

Gitjas commented 3 years ago

Yes, it needs to be installed before. I mixed up the wording. Probably in all my mods, lol.

GitHub shows this and your revision of the Polish translation as "drafts / work in progress" and I can't merge them as far as I see. Are you still working on them or how do I merge them?

Roberciiik commented 3 years ago

Yeah, I know, because I worked sequentially so it contains changes from previous commits. That's why I tagged them as draft. I will rebase changes after previous pull requests are merged

Roberciiik commented 3 years ago

Hi Jastey, this PR is ready to merge.

Note that I've translated these lines in the revised Polish commit, so Polish version is not included here.