Closed nina-py closed 3 years ago
Marking this as draft for the time being while I work on the following:
Rebased on the follow-up fixes branch, now to finish the remaining tasks...
All done and ready for review!
@jpetto, thank you for merging this! I have found that stories from some online publications fail, many blogs fail, but what is guaranteed to work are articles from CNN, CNBC, The Guardian, as well as GitHub issues. Bug noted - will have a look at it over the coming days.
thank you for merging this! I have found that stories from some online publications fail, many blogs fail, but what is guaranteed to work are articles from CNN, CNBC, The Guardian, as well as GitHub issues. Bug noted - will have a look at it over the coming days.
fwiw, i don't think this is/was a problem in this application. i tried adding stories directly through the graphql playground offered by aws and got the same errors, which makes me think the issue is somewhere on the infra/API side.
Goal
To be able to add a prospect from the Add Story page by supplying the URL of an article.
Implementation Decisions
Added @material-ui/icons (needed a closing icon to make errors dismissible).
Updated tests: removed Apollo-related tests from App.test.tsx, added tests for AddStoryPage.
Note that on success the page redirects to the Edit & Approve page that is not implemented yet, so if everything is fine you will see a blank page and just the URL will be updated to the path for that page, i.e.
/en-US/prospects/article/edit-and-approve/abcd-1234-efg-567/
, whereabcd...
is the actual prospect ID that comes back from the API. I thought about putting up something temporary but then decided not to as that way I'll be able to submit a completely independent PR for the Edit & Approve page and deal with minimal merge conflicts later on.Closes #97.