Closed nina-py closed 3 years ago
I had this issue earlier this week. I even set up a separate checkout and that second checkout also didn't work. Only in my case I couldn't get the 'main' branch going after you merged one of my PRs.
I thought this might be a browser caching issue but it didn't work in Chrome either. I suspect it was an issue with the local GraphQL server, but it wasn't fixed with restarting the API server, the only thing that fixed it for me was a complete reboot of my laptop.
We should update the readme instructions when we get the chance on how to get started with the repo as it is.
@kkyeboah, thank you for pointing this out - some of the script names have changed since I last edited the README file. Addressed in #124.
Goal
Update Prospects tabs so that each view shows customized cards with the correct buttons and labels.
Each Prospects tab now shows the appropriate buttons (these are not yet wired to anything).
All tabs except the default ("Pending") tab show prospects with labels ("Rejected", "Approved", etc.) as noted in the "Frontend Questions" document.
Card component has been reworked to be mobile-friendly and match Figma comps.
Implementation Decisions
As noted in the "Frontend Questions" document, I have dropped the "Edit & Approve" button from the "Rejected" tab.
Labels are green (primary color) for Approved/Live/Scheduled prospects, brick red for Rejected prospects and default grey for Snoozed prospects.
In desktop view, thumbnail images now take up ~33% of the available width rather than 30% they used to be - instead of custom styles, I'm using MUI grids and this also seems a closer match for Figma comps.
Also, I took out the unnecessary URLs out of the buttons that should just perform a mutation without redirecting the user anywhere - this solves the flicker of a URL change noted by @kkyeboah in a recent review.