Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account
https://getpocket.com
MIT License
278 stars 49 forks source link

feat(safari): iframe for injected script #117

Closed collectedmind closed 5 years ago

collectedmind commented 5 years ago

Goal

Inject iFrame into the page to use as a staging area for UI

Acceptance Criteria:

Implementation Decisions

We do this to avoid collision. This may not be entirely necessary given the context the safari scripts run in, but it will isolate css which has traditionally encountered edge cases with collisions.

collectedmind commented 5 years ago

This feels like it is out of scope given our timelines. The context in which things runs make injected scripts unable to access to the safari API. There is talk this will be fixed in future versions, but until we are certain users won't be affected, I would rather deal with occasional style collisions.