story(analytics): tagging analytics - add contextual info

[nelsonomuto]

Expected Behavior

For both chromium and safari 12 browsers. We should be sending contextual data along with the request to add tags in an actionInfo parameter.

                var actionInfo = {
                    cxt_ui: 'popover',
                    cxt_view: 'ext_popover',
                    cxt_url: sender.tab.url,
                    cxt_suggested_available: request.analytics.cxt_suggested_available,
                    cxt_enter_cnt: request.analytics.cxt_entered,
                    cxt_suggested_cnt: request.analytics.cxt_suggested,
                    cxt_remove_cnt: request.analytics.cxt_removed
                };

Similar to how the legacy extension repo had it as outlined here: https://github.com/Pocket/Extensions/blob/04e280e3999beb5e63365e8d9b5a8294c520ef25/src/app/background/background.js#L507-L519

Safari Swift API

For safari 12 this may need to be updated in the swift layer. @collectedmind

Actual Behavior

Currently this context info is not being sent with the request to add tags, we are only sending a bare bones object with the tags to be saved

{
    "actions": [{
        "action": "tags_add",
        "item_id": "989233",
        "tags": ["aa", "fad"]
    }]
}

legacy safari

For tag_added actions being sent from the Safari extension, I see some context data on those actions that I would like help interpreting.

-cxt_suggested_available = # of suggested tags the user saw on that item when they went to add a tag -cxt_enter_cnt = # of tags they added to the item -cxt_suggested_cnt = # of the tags they added that were suggested tags -cxt_remove_cnt = # of tags they removed -cxt_premium_status = 0/1 depending on if user is a premium user https://pocket.slack.com/archives/C1D0DKFLL/p1566508132005900

Steps to Reproduce the Problem

1. Save an article to pocket
2. Add a tag
3. Verify the network request parameters in the devtools or a tool like Charles Proxy POST getpocket.com/v3/send/

Specifications

• Version: 3.0.6.8
• Browser: Chrome, Safari
• Operating System: macOS Mojave 10.14.5

[audie1]

[audie1]

I'm seeing the correct values arriving for the add_tags action as they are logged here...

https://docs.google.com/spreadsheets/d/1hO1z5H0PzZkPjjUWK_RYaXS-KO9QcxCNhWpOdQPrh7Q/edit?usp=sharing

Looks like this is fixed!

[audie1]

@nelsonomuto looks good