refactor(structure): reorganize for more portability

collectedmind commented 5 years ago

Goal

Create clear separation between presentation layer and data layer

Todos:

[x] Add .env for better imports
[x] Update imports
[x] Move to elements/modules/views structure
[x] Update storybooks to reflect new structure
[x] Add better mock data

Implementation Decisions

The main goal here is to make some structural improvements so we can build a presentation only layer to interact with the swift data layer. Prior to this presentation was mixed in with some of the business logic, making it easy to fall into lazy patterns and have more tightly coupled components.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

nelsonomuto commented 5 years ago

Missing dep ERROR in ./src/components/modules/tagging/tagging.stories.js Module not found: Error: Can't resolve 'lodash.samplesize' in '/Users/nelsonomuto/pocket/extension-save-to-pocket/src/components/modules/tagging' @ ./src/components/modules/tagging/tagging.stories.js 6:0-43 37:14-24 38:12-22 39:17-27 77:12-22 78:10-20 79:15-25 @ ./src sync .stories.js$ @ ./.storybook/config.js @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true

collectedmind commented 5 years ago

Added that dependency to package.json

nelsonomuto commented 5 years ago

Looks good to me!

Pocket / extension-save-to-pocket