Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account
https://getpocket.com
MIT License
278 stars 49 forks source link

fix(analytics): update analytics to match requirements #159

Closed nelsonomuto closed 4 years ago

nelsonomuto commented 5 years ago

Goal

Do not merge until develop and master are reconciled The purpose of this PR is to make sure that the analytics context data in the spec https://docs.google.com/spreadsheets/d/15YIc9n0eqOA9soD_NleEqED49Tqy5p4S9a5IHDN8BeI/edit#gid=0 is being passed along in the js api calls.

• Related to goals in #139 and #120 however for immediate use in a chrome release not just for the safari migration • Use as a basis for determining changes required for #120 as the safari build cannot be tested in chrome.

Todos:

Implementation Decisions

Update api action handlers to accept the context parameters and add them in the api call.

All Submissions: