search

Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account
https://getpocket.com
MIT License
272 stars 46 forks source link

fix(safari): re-auth after account access is removed #188

Open stephshelley opened 4 years ago

stephshelley commented 4 years ago

If you remove account access via http://getpocket.com/connected_applications.php, the extension won’t save and throws an error. Instead, it should attempt to re-auth. https://www.dropbox.com/s/bj7lwepy1wju6et/Screenshot%202019-09-20%2017.01.59.png?dl=0

The only way I see to clear this error is to log out of Pocket and log in again.

collectedmind commented 4 years ago

@jrochell Do you have any insight into why we add our extension to this list in the first place? This makes sense for 3rd party apps that you would want to deny access to your Pocket account. Since this is a first party app, it seems odd that it is included.

jrochell commented 4 years ago

That's a good question. I can't say I know definitively why we include 1st party apps and extensions, but I think it's related to account security and something that has been helpful for users within support interactions.

For example, I seem to recall one instance where someone gifted an old device than happened to still be logged into Pocket, and by removing access to the app, they could make sure that the new owner of the device could not access their Pocket account.

For extensions, it's a bit less clear why you'd need to remove access like that, but I can imagine that it might be helpful to log out of an extension remotely if you didn't want to be logged in on that computer anymore.

If you want more technical details about why we want 1st party apps there, I think Matt or maybe Brian would be good people to ask.