fix(tags): fix disappearing popup while updating tags on new website

nelsonomuto commented 5 years ago

Goal

Fix #65: popup closes while typing tags

Root cause

The root cause seems to be that upon tag input the cancel close request is not being called so once the timeout reaches the popup is closed even while the user is typing a tag.

Todos:

[x] Reproduce issue ( steps outlined in #65 )
[x] add a tag input focus action whenever input receives focus
[x] trigger cancel close request when input receives focus

Implementation Decisions

Approach

I decided to add a tag input focus action and saga that ensures cancel close request is explicitly triggered whenever the tag input receives focus.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

suiluj commented 4 years ago

so what about this fix? the problem still exists.

argarner commented 4 years ago

This issue has existed the last 2 - 3 years I've been using pocket (and the chrome extension on MacOS). The lack of any updates to this extension (and this PR sitting open) for almost a year makes me doubt the future of pocket and consider jumping ship to a competitor like raindrop.

collectedmind commented 4 years ago

Closed in favor of rectifying some outdated code. This has been captured in #214 and will be addressed there.

argarner commented 4 years ago

@collectedmind Thanks for finally getting to this. Any idea why it took so long?

Pocket / extension-save-to-pocket