Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account
https://getpocket.com
MIT License
273 stars 48 forks source link

fix(safari): basic dark mode support #204

Closed dskuza closed 4 years ago

dskuza commented 4 years ago

Fixes #201

Goal

Fix #201: basic launcher dark mode support

Todos:

Implementation Decisions

Assets were taken from design here and updated within the project to add support for dark mode. By removing the explicit background color, the launcher takes the color of the window based on the selected system theme (i.e white for light, black for dark).

All Submissions:

dskuza commented 4 years ago

@nzeltzer @collectedmind please add the correct label(s) / project(s) / milestone(s) as required

nzeltzer commented 4 years ago

@dskuza Let’s get Jen’s eyes on this before merging.

dskuza commented 4 years ago

@nzeltzer Re-review requested as I made a change to explicitly set window color for OSes < 10.14 (when dark mode was introduced).