search

Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account
https://getpocket.com
MIT License
272 stars 46 forks source link

Add autofocus on tags input #47

Open avdieiev opened 6 years ago

avdieiev commented 6 years ago

Expected Behavior

Pocket tags input should be focused, when saving

Actual Behavior

Pocket tags input isn't focused

Steps to Reproduce the Problem

  1. Open page
  2. Click "Save to pocket"

Specifications

collectedmind commented 6 years ago

👍 Thanks for pointing this out @avdieiev

I implemented this fix and tested it locally. This will be included in the next release.

collectedmind commented 6 years ago

50 - We need to finalize copy and then update all locales.

feargswalsh92 commented 6 years ago

Does this mean that the cursor would automatically move to the tags box when you either hit the pocket button or your keyboard shortcut? If so yes this would be a great addition, if not I would like to create a new issue and have a crack at it.

collectedmind commented 6 years ago

@feargswalsh92 Yes, that is the intent. This functionality is complete and ready to add. It will live behind a feature flag under options.

Love that you want to contribute! Always open to suggestions and PR's

We're gonna try and lay out a road map of new features prior to releases and get a better release cadence worked out soon. This should give a clearer picture of good places to jump in.

feargswalsh92 commented 6 years ago

Awesome! In the meantime I'll trawl the code base for typos 😄 . I don't know for sure but I feel like even if the feature is turned on it should still require hitting the tab button to activate it to focus on the tabs box. I'm imagining a very particular use case where the user is already typing, wants to pocket the page they're typing on and doesn't in that instance want to add tags. Especially if it means that they need to move the cursor back to the text box they're typing on. As this recreates the problem that this feature is trying to solve in reverse.

adsk2050 commented 4 years ago

Hey @nelsonomuto ! Is this feature implemented? If not, I am interested in taking up its development. Would love to have a chat today.

DishantPal commented 1 year ago

Hi, any updated on this feature? with the extension shortcut, this is the only feature missing in my workflow.

ljubadr commented 2 weeks ago

Any update on this?