[P19-1160] Add Swift Bridge - Githubissues

Pocket / extension-save-to-pocket

Save to Pocket is a browser extension that is used to save pages to a connected Pocket account

https://getpocket.com

MIT License

278 stars 49 forks source link

[P19-1160] Add Swift Bridge #91

Closed nzeltzer closed 5 years ago

nzeltzer commented 5 years ago

Goal

Add necessary API to bridge Swift/JS communication.

Todos:

[x] Trigger save from right-click context menu item
[ ] Trigger save from keyboard shortcut
[ ] Set/get key/value storage
[ ] Set toolbar icon dynamically
[ ] Localize right-click context menu item

Discussion

Trigger save from right-click context menu item

Instructions for how to register for the event from Javascript are provided here:

document.addEventListener("saveToPocket", handleContextMenu, false);
function handleContextMenu(event) {
   ... etc ...
}

nelsonomuto commented 5 years ago

@nzeltzer using add/safari as the base for these PRs

nzeltzer commented 5 years ago

@nelsonomuto I still have quite a few checkboxes to go before this will be ready for review.