search

PocketMine / PocketMine-MP

Legacy PocketMine-MP repository. Head to https://github.com/pmmp for up to date software.
https://www.pocketmine.net/
GNU Lesser General Public License v3.0
1.25k stars 661 forks source link

Revert 2 herofied1180 patch 1 #4141

Closed sylv256 closed 8 years ago

sylv256 commented 8 years ago

Adds support for 0.14.1 and 0.14.0.

sylv256 commented 8 years ago

How do I get my phar download for my pull request?

extremeheat commented 8 years ago

... test out PRs locally before you submit them publicly to a repo. You don't need 3 PRs for the same exact thing -- if you were rejected once, why would you abruptly make another PR? Have you implemented the 0.14.1 protocol changes? I don't see that (and if you don't know what changed, you should not be making updating the protocol version).

Squash your commits (I've said this twice), implement the protocol changes and stop getting ahead of yourself. It's not just a matter of changing some files, and saying "I'm done."

I'd go as far to say that you are abusing the PR system, if that isn't clear to you.

sylv256 commented 8 years ago

Well how do I just access my phar file here to my pull request (I'm a newbie btw to the pocketmine dev world and I think that what your saying is offensive)? I am deleting your post.

Intyre commented 8 years ago

Protocol changes are there for a reason. Don't accept multiple protocol version! 12 Commits for a small change? Squash it! Need more help? Use the forums!