search

PocketMine / PocketMine-MP

Legacy PocketMine-MP repository. Head to https://github.com/pmmp for up to date software.
https://www.pocketmine.net/
GNU Lesser General Public License v3.0
1.25k stars 661 forks source link

hot bar sometimes randomizes repetitively #4158

Closed stayandwait closed 6 years ago

stayandwait commented 8 years ago

I'm using Minecraft Windows 10 Edition to connect to the server I created. When I change to a different item in my hot bar using scroll on the mouse, it will randomly select between 2 items repetitively.

Steps to reproduce: -Use the middle click scroll wheel to select items in the hot bar, scroll select as much as you can with the mouse. -You should now see randomizing between 2 items happening. It's quite irritating.

PocketMine-MP: 0.14.0 PHP: 7 OS: Windows 10

extremeheat commented 8 years ago

I've also seen this issue. It's not just limited to inventory swapping, but picking up items and dropping them.

The client and server get stuck into a nearly endless argument that results in packet spam from both directions.

Simple solution that I've seen is to just acknowledge the change and not echo the packet back unless it's not a legal action.

stayandwait commented 8 years ago

How would I do that?

Pub4Game commented 8 years ago

However, this works fine in a MiNET so it is confirmed

extremeheat commented 8 years ago

Yeah, MiNET doesn't seem to echo the packet back to the client so it fits in with my findings :p

Anyways this may be an issue with slot mapping differences in the Windows 10 Edition. But the easiest way at least in my opinion is to just not echo the packet back.. that way we can avoid potential side effects in PE.

dktapps commented 6 years ago

This has long since been fixed on PMMP's PocketMine-MP.