search

PocketMine / PocketMine-MP

Legacy PocketMine-MP repository. Head to https://github.com/pmmp for up to date software.
https://www.pocketmine.net/
GNU Lesser General Public License v3.0
1.26k stars 660 forks source link

Add support for 0.15.4 #4254

Closed buchwasa closed 7 years ago

extremeheat commented 8 years ago

Based on your PR, there's been absolutely no protocol changes, am I right?

buchwasa commented 8 years ago

Only one protocol change

extremeheat commented 8 years ago

Which is? Shouldn't your PR address the change then?

dktapps commented 8 years ago

Wooo, you guessed the magic number. Great. Now, what actually changed? Protocol version numbers don't get changed for no reason.

jojoe77777 commented 8 years ago

Version numbers don't get changed for no reason.

I think it may just be because of the new skin pack.

dktapps commented 8 years ago

@jojoe77777 I was referring to the protocol version, not the game version. I'll update my earlier comment

jojoe77777 commented 8 years ago

@dktapps Yes, I was also referring to that. I was wondering what would happen if someone with a new skin could join a sever with older clients... The older clients wouldn't be able to render the skin properly, so it would need a protocol bump so that doesn't happen. There may also be another reason for the bump.

extremeheat commented 8 years ago

@jojoe77777 custom skins can already be used, so I don't really see what you're referring to here. Unless massive things changed with the skin rendering model, or how skins are transmitted, there would be no protocol-related changes, in this regard.

robske110 commented 8 years ago

Well the client wouldn't be able to render these skins in the old version

dktapps commented 8 years ago

@extremeheat is right. Thank you, you beat me to it.