PocketMine / PocketMine-MP

Legacy PocketMine-MP repository. Head to https://github.com/pmmp for up to date software.
https://www.pocketmine.net/
GNU Lesser General Public License v3.0
1.26k stars 660 forks source link

PSR-2 violation #4260

Closed SOF3 closed 6 years ago

SOF3 commented 8 years ago

I don't need to give examples where this principle is violated, do I? https://github.com/PocketMine/PocketMine-MP/search?utf8=%E2%9C%93&q=public+abstract+function&type=Code

robske110 commented 8 years ago

maybe it was planned to violate 'em?

SOF3 commented 8 years ago

@robske110 the contribution guidelines meant to follow the PSR-2 apart from the specified exceptions, but it comes out that this rule is not followed either, so it should be written out.

Furthermore, sometimes it is followed and sometimes it is not followed, so I used SHOULD rather than MUST.

dktapps commented 6 years ago

This is obsoleted by changes in the PMMP repository.