search

Podcastindex-org / aggregator

Code, docs and discussion related to the Aggregator.
MIT License
16 stars 10 forks source link

Checking for the SRT MIME type. #16

Open ryan-lp opened 2 years ago

ryan-lp commented 2 years ago

The following two lines of code appear to assume that the SRT MIME type contains srt:

https://github.com/Podcastindex-org/aggregator/blob/c02d73e730fe3ce14a3ef40c3c0b19caca2ad82e/partytime/partytime.js#L851 https://github.com/Podcastindex-org/aggregator/blob/c02d73e730fe3ce14a3ef40c3c0b19caca2ad82e/partytime/partytime.js#L875

And for example, the Podcasting 2.0 RSS feed uses application/srt.

However, the conventional MIME type for SRT files (also recognised in the spec) is application/x-subrip, so the code should probably be forgiving and accept both MIME types.

daveajones commented 2 years ago

My code has diverged from this repo so I’ll go look and see what is going on currently. Thanks for pointing this out.