Players-Related Issues in 1.2.1.1

[TrazLander]

Uhh letsee, calling people that have done stuff on the Players Tool: @podshot @naor2013 and @martinhanzik . Also @Khroki just cause.

1. Players (their 3D graphic heads in the world) are no longer shown, except the single player “Player”. They just don't seem to show.
2. "Add Player" and "Remove Player" is broken. It adds the player but also throws an error that it can't pull up the UUID. Though maybe it's just something at the moment and the skins server is down...who knows.
3. If you can, make it so that “Player” is always at the top of the Players List (if it exists), so it is the first one selected when you enter that menu. Not sure what ordering it’s using currently, but it sure isn’t alphabetical:
4. When there are No Players (including deleting “Player”), it shows [No Players] AND Player. -Hitting Goto Player does nothing. -Hitting Move Player crashes mcedit. -Hitting Move Player on [No Players] also crashes MCEdit.
5. Allow for deleting “Player”. -Currently an error is thrown up "Can't delete the default Player". I usually have to open an NBT Editor to delete “Player” before allowing the map for download. This is standard practice for many mapmakers. So why not allow deleting “Player” using mcedit. MCEdit already accounts for this on world load by sending you to the World Spawnpoint if "Player" doesn't exist.

[freundTech]

Fixed number 3.

[freundTech]

6483a0aee5c3503b4449600e6b78788612e8602f fixed issue 1. and 2. Also fixed the slow world loading. It was all caused by one line. (Blame @LaChal :P )

5 is on purpose, but I can change it. Haven't looked at 4. yet.

Edit: also fixes parts of 4. Goto and Move now work again.

[Rubisk]

Can you replace 5 with a warning: Are you sure you want to delete the standard player?

[naor2013]

Fixed 4 and 5 so all of those are fixed now!

[TrazLander]

Can you replace 5 with a warning: Are you sure you want to delete the standard player?

I agree. It shouldn't be so easy to remove that player.

[TrazLander]

Can you replace 5 with a warning: Are you sure you want to delete the standard player?

I agree. It shouldn't be so easy to remove that player.

@naor2013 Added with https://github.com/Khroki/MCEdit-Unified/commit/63fd13ea25c5c79556937c152b2ba55c20665649

[TrazLander]

Fixes for 1-5: f5a177d3b7988f34cd7736f397dcbaf435d3d415 Some changes to Player and Raycaster d8ebd09f92fe94e366f869cf8ac8c384d2ef444c Removed prints ef9e842c9e4ef7fce9c1b6abb9919761bb72d4ed Fix for player always showing when there's at least one player 21bb6d1d0a032c07a280aaff4f86aa4ea8035108 Fix undo for removing player doesn't work 63fd13ea25c5c79556937c152b2ba55c20665649 Added warning when removing Player and fixed a small bug

1. done!
2. done!
3. done!
4. done!
5. done!
6. For removing "Player", can: -Enter press Yes -Esc press Cancel Note: As a rule-of-thumb, whenever the button is Blue like that, Enter should work on it?
7. After you cancel trying to remove "the default Player", it still adds an unsaved edit.
8. Removing a player, and then hitting Undo, adds that player back in at the bottom of the list and doesn't re-sort. (using "Add Player" seems to sort new players just fine)
9. Can you center-align "Player Name" at the top of the sidebar. Maybe even underline it. If neither of those, then maybe just add a colon. Also change it to "Player Names(s)".
10. When you add a player using "Add Player", by default it should place them at the World spawnpoint, not at 0,4,0. (bonus if it can add to the y value to place them on the highest solid surface and within two spaces of air above the world spawnpoint)
11. Clicking "Reload Skins" when your internet is down/you're offline, gives this error: I mean an error is probably ok, but that error seems pretty quick and easy to detect, so it should give a nicer warning "Could not connect to the skins server, please check your internet connection and try again."
12. How easy would it be to add a loading bar whenever it's pulling skins/uuids. I'm guessing not too easy. But the check/download sure takes long enough to warrant it sometimes. Feels like mcedit is frozen. At the very least there should be a hover-text warning when you place your mouse over the "Reload Skins" button that says something like "This pulls skins from the online server, this may take a while".
13. Typos on the error for trying to add an invalid username: -remove the comma -"connectedto" should be "connected to" -and add a period at the end after "exists".
14. Remove the advice text "Click to move the player" at the bottom, just leaving it blank: It doesn't make sense anymore since you can do more then just "Move Player". It would also be super redundant to change it to: "Click the "Move Player" button to Move Player." Just leave it blank for now unless someone has a better idea of what to put there.

[naor2013]

Added 6 (And no, you can't press Enter) Fixed 7 by not remembering every failed operation (Took a while to cover all of the operations! lol) Fixed 8 Working on the rest..

[naor2013]

Didn't fix 6.. Fixed 9 and 10 now

[naor2013]

Fixed 13

[TrazLander]

Some fixes for 7, 8, 9, 10, 13 75eb53cb2015899fe7ca2923badfd23f545b0e94 Changed title 94fe4652b7b8c260d64664d08d31c00de98ebcbe Fix for undo and redo 2191ed54edb128a7e59e819e30a04c5b08cd2dda Small fix fdaa403dda8842b772565a4cee2259ebb59ec9dd Another fix 31b2521d7d00679cbcf3e546abce9c71dda61dbf Fixed adding players setting them at 0,4,0 1a89b130c5c2c01f2542abc112738da340e9d098 Fixed a typo

1. done!
2. done!
3. done!
4. done!
5. done!
6. For removing "Player":
   • Can Enter press Yes
   • Can Esc press Cancel
7. done!
8. done!
9. done!
10. done!
11. Clicking "Reload Skins" when your internet is down/you're offline, gives this error: I mean an error is probably ok, but that error seems pretty quick and easy to detect, so it should give a nicer warning "Could not connect to the skins server, please check your internet connection and try again."
12. How easy would it be to add a loading bar whenever it's pulling skins/uuids. I'm guessing not too easy. But the check/download sure takes long enough to warrant it sometimes. Feels like mcedit is frozen. At the very least there should be a hover-text warning when you place your mouse over the "Reload Skins" button that says something like "This pulls skins from the online server, this may take a while".
13. done!
14. Remove the advice text "Click to move the player" at the bottom, just leaving it blank: It doesn't make sense anymore since you can do more then just "Move Player". It also would be super redundant to change it to: "Click the "Move Player" button to Move Player." So just leave it blank for now unless someone has a better idea of what to put there.
15. Placing a player using "Move Player" places them at -.05 from where they should be placed.
16. A player getting auto-placed when added needs to add .5 to their x and z coordinates so they are placed at the center of the block.

[Podshot]

I can do 11 and 12 later today

[TrazLander]

@Podshot I seem to be getting this error most of the time when hitting Reload Skins multiple times in a row (with my internet up):

[Podshot]

It seems that Mojang implemented a request limit to their session server API, which is creating invalid image files, and refusing to reload after previously reloading. I will have to re-write the Player head texture code to use skins.minecraft.net

[L3ice]

Which server did you used before? So MCEdit used the outdated server?(http://s3.amazonaws.com/MinecraftSkins/) Why did you use the outdated server? Or am I wrong?

[Podshot]

We used Mojang's session servers, which I did not realize had a request limit.

[Khroki]

Status text has been blanked.

[TrazLander]

12 - For this:

How easy would it be to add a loading bar whenever it's pulling skins/uuids. I'm guessing not too easy. But the check/download sure takes long enough to warrant it sometimes. Feels like mcedit is frozen. At the very least there should be a hover-text warning when you place your mouse over the "Reload Skins" button that says something like "This pulls skins from the online server, this may take a while".

I meant more like this: But for the "Reload Skins" Button. Just add the warning to some hovertext. Dunno if it needs a prompt to pop up like @Podshot added. Seems like an excess mouseclick!

15 - Placing a player using "Move Player" places them at -.05 from where they should be placed. Here's a nice 3 screenshots to show it since @naor2013 didn't seem to understand! :P

15a. My current position at y=86.8155646929 15b. Moving myself to y=65 (the obsidian block I'm placing on is at y=64) 15c. I get put at y=64.95 instead of y=65.0

17 - Also for the above screenshot (15c), notice how the player head is visually placed up 4 pixels higher then it should be. It should be placed at the exact height of the obsidian line. Did codewarrior make it do that on purpose for some reason? Why not just put it at the exact position it should be?

16 - A player getting auto-placed when using "Add Player" needs to add .5 to their x and z coordinates so they are placed at the center of the block.

18 - The skin display when hitting "Move Player" is sporadically wrong. At least I'm pretty sure my skin doesn't look like that. :P I'm not totally sure how to reproduce this, but add several players, and then click through them all and hit "Move Player" for each one and see if the skins change correctly (as long as you know what their skin looks like!)

19 - I got this error: Using "Undo" on some stuff. I'm not fully sure how or why. And I don't feel like testing and figuring it out because I'm falling asleep at my keyboard atm. But knockyourself out anyway! I'll try to reproduce it tomorrow! zzzz

[naor2013]

Fixed 19 The problem was that when adding a player and leaving the Players tool, undoing doesn't work

[TrazLander]

20 - Should the sidebar be wide enough to accomadate Player UUIDs getting displayed? Is it possible to make it scale to a wider width if there ARE uuids in the box? I'm guessing no. Might have to wait on this one if scaling it to the size of UUIDs isn't easily possible until removing Albow.

[Rubisk]

Is it possible to make it scale to a wider width if there ARE uuids in the box?

Yes, if UUID width == x else width == y

[TrazLander]

Then should totally do that! :P

[Khroki]

Closing because this is mostly done and is becoming a mess, make a new issue if there's still something to be done.