Podshot / MCEdit-Unified

Combined MCEdit & Pymclevel repository.
http://podshot.github.io/MCEdit-Unified/
ISC License
484 stars 109 forks source link

Confirmed pocket bug list #676

Open Khroki opened 8 years ago

Khroki commented 8 years ago

Downloaded the Windows 10 edition of Minecraft, and here are the bugs I have confirmed. This thread is so we can see what all needs to be done. If you have another bug please open a new issue, I'll add it to here once confirmed.

I have heard about MCEdit supposedly not loading some chunks, but I haven't been able to reproduce even with some large worlds, if someone could provide a world with this bug and tell me where chunks are missing (a screenshot), that would help.

LaChal commented 7 years ago

I agree with @neonerz .

Please, open a new issue(s) here to talk about subjects which are not MCEdit PE known bugs. A good idea may be to transfer the messages not related to this thread to new one(s), even by copying/pasting. (This will let me do a sort of clean-up of this thread.)

BTW, I could not test yet the filter you created, neonerz, but I look at, and I guess the logic is good. It needs some enhancement, but, anyway nice stuff :smile:

neonerz commented 7 years ago

yea, sorry about that @LaChal. A bit later I'll go through and delete the non-relevant posts and move posts related to actual bugs (not mentioned in the OP post) into a new issue.

edit // removed most of my off topic posts

ghost commented 7 years ago

@LaChal Please send me your LevelDB-MCPE.dll for 1.0+ worlds. It doesn’t compile for me. No z.lib. I am Win10 x64

LaChal commented 7 years ago

@NFGamerMC The .dll is already in this repository (in the pymclevel folder). Personally, I don't compile it. I'm running on a non Windows OS.

To compile it on Windows, you'll have to install Visual Studio, and the Windwos SDKs on you system, then get the sources from there: https://github.com/jocopa3/leveldb-mcpe. Pay attention to the zlib @ 4a090ad. It's the link to Zlib sources. You'll need them to compile.

ghost commented 7 years ago

Thanks, also @LaChal How do I run MCEDIT from this repo on Windows?

LaChal commented 7 years ago

You'll need to install Python 2.7 and the dependencies as stated in the readme. Just adapt the command for Windows :)

neonerz commented 7 years ago

I'm not sure if you are aware @LaChal there seems to be an issue in windows. I'm not sure if it's the DLL that's packaged with it or something else, but if you save a world in windows, it clears the seed and resets the world name (among other things)

LaChal commented 7 years ago

Right, it has been reported in #801.

I tried to compile it on my side, but no chance (yet).

All right. I could finally compile something for 64 bit systems (using VS 2017 community edition): LevelDB-MCPE.dll.zip

Editing a PE 1.1 world: Loaded, saved unmodified, closed, reloaded: level name and seed unchanged. Loaded, saved modified (added a sign), closed, reloaded: level name and seed unchanged. Closed MCEdit and reloaded the modified world: level name and seed unchanged.

All the same with PE 1.0 worlds.

These tests has been done in MCEdit.

neonerz commented 7 years ago

I just tested using commit b735277 (the latest commit from @Podshot is spitting a TON of errors to the console, though works otherwise) and your DLL. I'm still having the issue.

Inside MCEdit it looks fine, but when I load the world in PE, Minecraft reports it with no name, seed 0, game mode reverted back to survival, and world type reverts back to Infinite.

Here's an example world I simply opened, and saved. In MCEdit "World Info" looks right, but if you open it in MCPE, it's different. brewing-stand.zip

Podshot commented 7 years ago

@neonerz Yeah, I completely broke some parts of the code, could you give me pastes of the errors to make sure I fix all of them?

neonerz commented 7 years ago

@Podshot I went to reproduce the errors I was seeing, but it seems you must have fixed it in the 6/30 commits. I'm not getting the console spam anymore.

neonerz commented 7 years ago

@LaChal - I found a slight work around for the Windows issue. If you do all your work in Windows, save the world, then open it back up in Linux, and save it again. When you open the world in MCPE, the world info reflects the correct info.

With that in mind, it seems like Windows can't save to level.dat in the new format, and is only saving to level.dat_old (I assume this because if I use a NBT editor on level.dat_old on a world I edited in Windows, I actually see the changes).

LaChal commented 7 years ago

Hmmm...

No error in the console? No mention of corrupted, unreadable or unwritable level.dat in the log file?

neonerz commented 7 years ago

Nothing in either. Here's a mcedit.log of me opening a PE world in windows, changing the name, and then saving it. mcedit.log.txt

Also, here's a gif demonstrating it.

2017-07-03_15-24-11

LaChal commented 7 years ago

Hmmm...

MCEdit explicitely writes to level.dat, on any platform. level.dat_old will be loaded if level.dat is corrupted...

After some investigation on your 'brewing-stand', it looks like it's the same issue than the #810 one. The byte sequence '0a0d' is the Windows line ending/start. I guess something is replacing every '0a' byte with '0a0d' pair...

@neonerz It shall be fixed now.