search

Podshot / MCEdit-Unified

Combined MCEdit & Pymclevel repository.
http://podshot.github.io/MCEdit-Unified/
ISC License
484 stars 109 forks source link

MCEdit checking profiles for armorstand entities, makes loading saves take longer. #739

Open ShinkoNet opened 7 years ago

ShinkoNet commented 7 years ago

When opening a save where there are various armorstands being used, MCEdit sends http requests to the session server to find the armorstands' "usernames". This delays the loading of the saves.

[ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/00b83e645b313540bfb9c847da31dcc9" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/00b83e645b313540bfb9c847da31dcc9" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/30a1816e67fb39588e1ae72cc8ae31d2" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/36aa2c2b8d3d39148890a84457bdcd0a" [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/30a1816e67fb39588e1ae72cc8ae31d2" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/36aa2c2b8d3d39148890a84457bdcd0a" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/3aa091d71dd23569b6e38375a05c9976" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/3aa091d71dd23569b6e38375a05c9976" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/53dd3d27dcf63850998ec323a65fa82b" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/53dd3d27dcf63850998ec323a65fa82b" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/ba908e7ca8313900877d5613e31504ef" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/ba908e7ca8313900877d5613e31504ef" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/f705840679603fc08377cc0abb216175" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/f705840679603fc08377cc0abb216175" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/ffb778c782ec37078994c22093e85262" [ WARNING][ version_utils.py:367]:Error: 429 [ WARNING][ version_utils.py:366]:Encountered a HTTPError while trying to access "https://sessionserver.mojang.com/session/minecraft/profile/ffb778c782ec37078994c22093e85262" [ WARNING][ version_utils.py:367]:Error: 429

A suggested fix is to skip checking usernames that invalid (longer than 16 characters).

naor2013 commented 7 years ago

Do you have skulls on the armorstand? Like skulls of players? How do you know the issue is related to armorstands? Does MCEdit still works with this issue or is it crashing or not responding? How much time does it take?

Sorry for the questions but we need some leads to know what causes the issue.

ShinkoNet commented 7 years ago

I can give you the world download to test for yourself. It lags when loading it, but not when you are offline. There are no crashes. https://a.pomf.cat/lqzsjb.zip

LaChal commented 7 years ago

These check are made using the players UUIDs, not their names, so, shortening or not checking them won't fix the issue.

We already changed the behaviour of this part of code, and in the next release world loading time will be shorter, especially if you have a lot of players in the world. The player list will be updated when answers are recieved from the server. We also need to solve this 'Error 429' issue. Edit: this code is sent when the server receive too much requests.