Brushes - Adding/Fixing/Upgrading!

[TrazLander]

Done so far Rubisk's updated brush: https://github.com/Khroki/MCEdit-Unified/commit/be109c515f82a333279690e4ee4de60bb9df627c Added Various Replace

Issue https://github.com/Khroki/MCEdit-Unified/issues/80 Brushes ignore data values: Erode bugfixes: https://github.com/Khroki/MCEdit-Unified/commit/e297e36ed8023c84c1ba0678d59bb9430d4af10a https://github.com/Khroki/MCEdit-Unified/commit/fba11708c075663e538ac13755404f0d0e1c7b1e https://github.com/Khroki/MCEdit-Unified/commit/2b4514f782443b1fac3d3e865b55ad966eefaf1e Fixed "noise" option on erode brush not doing anything. Fixed an issue that messed up block data values when eroding.

Fixed FloodFill and some stuff https://github.com/Khroki/MCEdit-Unified/commit/6c9f93870bb3c1526360eb84fe97faa9f0c1d2c5 https://github.com/Khroki/MCEdit-Unified/commit/08cbf0e980786f58cd6d46cfbef6d81126420b2c

Fixed air checkbox off leaving squared selections: https://github.com/Khroki/MCEdit-Unified/commit/4b56fdd2122023df325f0609344f23a118d668a7

---

What else is going to be added! And any feedback for updates or anything people would like to see go here!

Currently there's few things under feature requests:

• https://github.com/mcedit/mcedit/issues/509 Save/load Brush Presets: Vechs Video Link isn’t this already there with the “Paste” option? Should it at least be expanded on or made more clear?
• https://github.com/mcedit/mcedit/issues/365 Brush tool should rotate the selected block along with the brush shape
• hotkey to rotate blocks independently of brush shape
• Custom brush classes imported similarly to filters; maybe pass in numpy array of desired radius_2 * radius_2 along with other parameters, and return modified chunk of blocks
• https://github.com/mcedit/mcedit/issues/21 [Was a Codewarrior future plan] Add an "Unpaste" brush mode for removing blocks in the shape of a selected .schematic

[Rubisk]

mcedit/mcedit#365 got some work done on this. Wanted to make an ALT+G and ALT+E key to rotate blocks seperately, but apparently mcedit doesn't support key combinations yet. sigh

I'll instead just add an option in the menu to rotate blocks with the brush. If you want to just rotate the block, I guess you'll have to reselect the block T__T

[Rubisk]

Added option to rotate blocks with brush, see pull request .

You can't rotate blocks individually yet, don't know what keys to bind it too. Also, apparently it's impossible to rotate a paste selection, working on that next I guess. And, apparently the key that you bind to "mirror" mirrors indeed the clone tool, but also works as roll key for the brush. In the brush tool, pressing the roll key does nothing. Might want to fix that?

[TrazLander]

@skinny121 in this https://github.com/Khroki/MCEdit-Unified/commit/4d6ce486723908ebbfd6495a45f536848fe98761 commit made it so clone and schematics now work for all blocks and not the schematic itself using Alt plus the rotate/roll/flip/mirror key (Alt+e,Alt+r,Alt+f,Alt+g). It should be added this way for these brush options too.

[Rubisk]

Brush Presets have been succesfully added in the master branch. Alt+E/G/R/F doesn't work, not on clone tool either.

[TrazLander]

Closing this as it's mostly complete in its current state and not currently active. Can reopen or just keep it closed and still use this for any ongoing discussion for improving brushes in the future!

[Khroki]

Reopening for the moment as I'm getting this if I use wireframe at the chunk border with W and L set to 17. Also that button needs some work.

[Khroki]

Also right after starting mcedit, clicking any of the presets always activates 1, works fine after that.

[Rubisk]

I fixed the brush preset always loading 1 the first time, don't know what is causing those weird borders though, like really don't. Will look into it ASAP.

[Khroki]

Problems fixed, thanks.

[TrazLander]

I fixed the brush preset always loading 1 the first time

Looks like you fixed it by making it select nothing at all. When you first load mcedit, there are no brushes selected: This creates a weird situation where you have a NULL brush that can only be accessed the first time you select the brush tool after opening mcedit. I think it should select "1" by default for new users of the program, and you should have it save last used brush and keep it selected even after you’ve closed and re-opened the program. If all that is possible...

Or another way to go about it is truely have a NULL brush that doesn't get saved. Something like having all the brushes 1 2 3 4 5 6 7 8 9 X Where X would deselect any saved brushes, and this would be the default state that would be selected when first open the brush tool, which is exactly what it currently does. So it'd just be a way to integrate what's currently happening.

[Rubisk]

Reworked presets a6a918c2ff327d196b33774dd16d194d545cefc7

[TrazLander]

did you mean to link the commit with that comment :P

[Rubisk]

What are you talking about? :D

[Rubisk]

Fixed tons of bugs and added remove option 32cbdf09a596a7353b61e1526575f54f95e10ec9

[Rubisk]

Next up is custom imported brush classes. Before I do that, I need to completetely revamp the setup of brushes. At the moment, it's really messy. Options are all over the place, called in 20 different ways, some using properties, some dictonaries, some just general 'static defs'(?). It's a mess, and needs to be cleaned up. I will try export all current brushes to files as well, makes for more consistent code, and just put those in your brushes folder? Or keep them somewhere in a standard folder?

[Podshot]

@Rubisk I can help you with the custom brushes if you would like

[TrazLander]

Closing this since it's mostly inactive now and main stuff is implemented.